Should we inline this method? Also, I am wondering if we could/should call this unconditionally? If `overCapacity()` is true, we might or might not expire records here (same if called unconditionally). If `overCapacity()` is false, but `buffer.minTimestamp() <= expiryTime` is true, we would expire record (same if called unconditionally). If both are false, `drainExpriredRecords()` would not expire anything if called either, because it passed in the corresponding boolean predicate anyway?
Ie, I _think_ we can just remove the `if` condition and execute the `then` part always [ Full content available at: https://github.com/apache/kafka/pull/5693 ] This message was relayed via gitbox.apache.org for [email protected]
