This really doesn't seem right to me. I've already unified as much as I felt appropriate by extracting several methods into IntegrationTestUtils, which is the place where we already share common code.
Beyond that, though, these are two different tests. They only do the same topology coincidentally. It seems needlessly complex to introduce an abstract class or some other secondary "test util" class to de-duplicate a few blocks of trivially simple code... It just makes the tests harder to read and maintain. [ Full content available at: https://github.com/apache/kafka/pull/5724 ] This message was relayed via gitbox.apache.org for [email protected]
