> This seemed to achieve a nice separation of concerns. Not sure about this:
With this PR, I don't see why we need to keep the "buffer" and the "state" separated? Logically, the "buffer" was an intermediate thing (incomplete feature) that should be replaced by (or converted into) a `StateStore` with this PR IMHO (ie, merge existing buffer class with this state store class) Suggestions: rename `TimeOrderedKeyValueBuffer` -> `TimeOrderedKeyValueBufferStore` and let `TimeOrderedKeyValueBufferStore extends StateStore`. Than `InMemoryTimeOrderedKeyValueBufferStore implements `TimeOrderedKeyValueBufferStore`. [ Full content available at: https://github.com/apache/kafka/pull/5724 ] This message was relayed via gitbox.apache.org for [email protected]
