Hi. Some remarks: I think !"".equals(s) is better than s.length()!=0 because more semantic and easy to read. What is "xwiki.dv" config option? (what does "dv" mean?). I think we need more meaningful params than "xwiki.db" and "xwiki.dv" (something like xwiki.db.mainname, xwiki.db.forceset ?)
Why we need to force setDatabase in non virtual mode? Is it only for fix security issues? Why we can't simply deny setDatabase in non virtual mode? Thomas Mortagne wrote: > Hi all, > > I would like the point of view of every ones for the patch provided in > http://jira.xwiki.org/jira/browse/XWIKI-2006 by Ruslan Shevchenko > (configurated_db_schema_06.patch). > > It allows to force the name of the database in the xwiki.cfg file. > Except for some very minor Checkstyle still remaining, the only > "problem" for me is than if this feature is enabled the number of > hibernates query in non-virtual mode grows to one more by hibernate > transaction used to ensure the selected database is the provided one. > Note that this is not worst than actual virtual mode which do almost > exactly the same thing for the same reason. > > For that reason and also because it touch one of the deepest part of > XWiki platform I want to validate a vote to apply it in the trunk. > > It also add database names prefix support which is great. > > Here my +1. -- Artem Melentyev _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
