On Thu, Mar 20, 2008 at 4:11 PM, Artem Melentyev <[EMAIL PROTECTED]> wrote: > Hi. > > Some remarks: > I think !"".equals(s) is better than s.length()!=0 because more semantic > and easy to read. > What is "xwiki.dv" config option? (what does "dv" mean?).
I think dv is an error in this patch, it should be db (correct me if i'm wrong). Anyway I will not apply this patch without any modifications and tests, plus it has to be recreated based on last source code from trunk. This mail is more to validate the concept of this implementation. > I think we need more meaningful params than "xwiki.db" and "xwiki.dv" > (something like xwiki.db.mainname, xwiki.db.forceset ?) > > Why we need to force setDatabase in non virtual mode? > Is it only for fix security issues? > Why we can't simply deny setDatabase in non virtual mode? What do you mean ? Actually setDatabase is never call in non virtual mode, it is forced in this patch only when a property says that XWiki has to use a provided database and not the default hibernate configuration file one. > > > > Thomas Mortagne wrote: > > Hi all, > > > > I would like the point of view of every ones for the patch provided in > > http://jira.xwiki.org/jira/browse/XWIKI-2006 by Ruslan Shevchenko > > (configurated_db_schema_06.patch). > > > > It allows to force the name of the database in the xwiki.cfg file. > > Except for some very minor Checkstyle still remaining, the only > > "problem" for me is than if this feature is enabled the number of > > hibernates query in non-virtual mode grows to one more by hibernate > > transaction used to ensure the selected database is the provided one. > > Note that this is not worst than actual virtual mode which do almost > > exactly the same thing for the same reason. > > > > For that reason and also because it touch one of the deepest part of > > XWiki platform I want to validate a vote to apply it in the trunk. > > > > It also add database names prefix support which is great. > > > > Here my +1. > > > -- > Artem Melentyev > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
