Another comment:

There's now a XHTML cleaner interface and a first implementation  
located in xwiki-xml. Could you please refactor the wysiwyg module to  
use it so that we have only 1 cleaner? Also I don't think we need 2  
cleaner implementations (jtidy + htmlcleaner).

Let us know what's missing so that we can add to it. The office GSOc  
project is also starting to use it and it's going to add some cleaning  
rules real soon so we should all work on it and make it the official  
xwiki XHTML cleaner.

Thanks
-Vincent

On Aug 23, 2008, at 4:35 PM, Vincent Massol wrote:

> Also I see you have a custom StringInputStream. What's the need vs  
> using a ByteArrayInputStream
> (http://java.sun.com/j2se/1.4.2/docs/api/java/io/ByteArrayInputStream.html)?
>
> Thanks
> -Vincent
>
> On Aug 23, 2008, at 4:33 PM, Vincent Massol wrote:
>
>> Hi Marius,
>>
>> Just to let you know that it seems the editor you've committed on  
>> last Friday doesn't use an updated version of the XWiki syntax and  
>> is thus out of sync with the renderer. For example:
>> * Bold is **bold**, not *bold*
>> * Macros use 2 curly braces
>> * etc
>>
>> We need to fix this ASAP since otherwise it won't work and we need  
>> to release a working version for 1.6M1 (not everything should work  
>> but easy stuff like this should work).
>>
>> Thanks
>> -Vincent
>>
>

_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to