On Nov 21, 2008, at 3:51 PM, Jean-Vincent Drean wrote: > On Fri, Nov 21, 2008 at 2:58 PM, Vincent Massol <[EMAIL PROTECTED]> > wrote: >> +1 in general but some comments to address: >> >> * I don't understand the "Fullscreen" text and the "/ ..." element >> next to it > > The link is supposed to be less visible, I've updated the mockup (and > I think there will be a little pop-out icon at the left in the end). > http://dev.xwiki.org/xwiki/bin/view/Design/NewWysiwygEditorInterface#HToolbars
Yes I think an icon/image would be better than text. >> * I see you've put Wiki and Wysiwyg tabs. What happens if I want a >> text area with only wiki mode or only wysiwyg editor? > > "2 models of toolbars will be available : one for classic textareas > (wiki pages, blog articles, generally speaking all large textareas) > and one for smaller textareas (comments, short descriptions)." > The light version of the wysiwyg editor is to be defined. ok so it's not part of this discussion I guess. >> * Where are located the other editors (objects, class, rights, >> history, etc)? > > This discussion is not part of this vote imho. > >> * Why are there some arrow ">" in some menu items but not in others? > > The arrows were here to make a difference between single entry vs. > multiple entries dropdowns but they are not relevant now, I've removed > them. > >> * Edit image properties --> Edit image >> * Edit macro properties --> Edit macro > > It reminds me a discussion about focusing on the meaning of words ;) > Since we don't provide an online image editor + we don't offer the > ability to edit macros from the wysiwyg I'm still +1 for keeping > "properties". > >> * I don't think we can have macros listed in the menu item. We need >> categorization + ability to search for macros to insert them so I'd >> rather have "Insert Macro" instead with possibly below (separated >> by a >> ---) a list of common macros with a "More..." button too. > > Looks better. I've updated the mockup accordingly. > >> * I'm not sure I like the where the help is located in the wiki >> editor. Also I think it might be good to have the same toolbar in >> wiki >> editor (this removes the need for the help there I think and we can >> instead have a reference help somewhere else or simply a "?" button >> that opens the help) > > "You can ignore the inline syntax help in wiki mode, it was just a > thought while doing the mockup." I know but you're asking to vote on the general toolbar layout. What I'm saying and which is an important decision is that we might want to also have toolbars for the wiki editor. >> * I'm not sure where "Justify left" is located, couldn't find it. > > "Don't pay attention to the text formatting toolbar, I've used > balsamiq > default widget and it is not a spec for our toolbar." I was commenting on the following text: "Hovering on a menu item such as "Justify left" highlights the item with a transparent dark background with a border" I wasn't sure what this was applying to? oh... could it be that you don't mean "menu item" but "toolbar item"? :) In which case I agree. Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
