asiri (SVN) wrote:
> Author: asiri
> Date: 2009-01-07 16:47:31 +0100 (Wed, 07 Jan 2009)
> New Revision: 15130
> 
> Modified:
>    platform/core/trunk/pom.xml
>    platform/core/trunk/xwiki-core/pom.xml
> Log:
> XAOFFICE-1: Develop the initial feature set for the Office Importer module
> 
> * Added xwiki-officeimporter module to platform/core/trunk/pom.xml as a 
> sub-module so that it's built when the core is built.
> * Added a dependency in xwiki-core to xwiki-officeimporter so that 
> xwiki-officeimporter get's bundled into XE.

This dependency should have <scope>runtime</scope> to reduce build time,
because otherwise the library and its dependencies are added to the
classpath during compilation and tests.

>      <dependency>
>        <groupId>org.xwiki.platform</groupId>
> +      <artifactId>xwiki-core-officeimporter</artifactId>
> +      <version>${pom.version}</version>
> +    </dependency>


This dependency should not be placed in the core, as it should be
inherited from officeimporter. If it isn't, then the officeimporter pom
is wrong.

> +    <!-- Required by jodconverter; see http://www.slf4j.org/faq.html#maven2 
> -->
> +    <dependency>
> +      <groupId>org.slf4j</groupId>
> +      <artifactId>slf4j-log4j12</artifactId>
> +      <version>1.4.3</version>
> +      <scope>test</scope>
> +    </dependency>


-- 
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to