Hi,

This dependency should have <scope>runtime</scope> to reduce build time,
> because otherwise the library and its dependencies are added to the
> classpath during compilation and tests.
>
> >      <dependency>
> >        <groupId>org.xwiki.platform</groupId>
> > +      <artifactId>xwiki-core-officeimporter</artifactId>
> > +      <version>${pom.version}</version>
> > +    </dependency>
>

Fixed.


> This dependency should not be placed in the core, as it should be
> inherited from officeimporter. If it isn't, then the officeimporter pom
> is wrong.
>
> > +    <!-- Required by jodconverter; see
> http://www.slf4j.org/faq.html#maven2 -->
> > +    <dependency>
> > +      <groupId>org.slf4j</groupId>
> > +      <artifactId>slf4j-log4j12</artifactId>
> > +      <version>1.4.3</version>
> > +      <scope>test</scope>
> > +    </dependency>
>

Fixed.

Thanks.

- Asiri
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to