On Thu, Nov 19, 2009 at 08:50, Vincent Massol <[email protected]> wrote: > > On Nov 18, 2009, at 5:16 PM, Thomas Mortagne wrote: > >> Hi, >> >> Since we introduce document footer informations view statistics are >> store several time for the same user view of a page. >> >> See http://jira.xwiki.org/jira/browse/XWIKI-4590 >> >> The issue is that theses tabs are loaded asynchronously in ajax and >> make a call using view action. >> >> Here are some solutions: >> 1/ introduce a new action "viewinternal", "service" or anything else >> that would be a "view" action without UI and not taken into account by >> statistics (that register for "view" action events) > > +0 > >> 2/ pretty much the same thing that 1/ but based on a URL parameter > > +1 > > This is much better to me since: > * Stats are a transersval concern, not related to the view action > especially. I'm pretty sure we can imagine use cases where we don't > want to register stats for actions other than view > * The way I'd like to implement the actions later on (xwiki-actions > module) is to have action pipelines and this "saving stats" action > will be implemented as a post-action that would be injected after the > main actions. Thus only this post action will need to check the > parameter which will be transparent to the other actions, thus > providing a good separation of concern.
So you want statistics module to go look at URL parameters ? How would you name this parameter ? Also i really don't like that ajax calls use the standard view action so the "viewinternal" action is needed anyway IMO. > >> 3/ use an additional AJAX request similar to a google analytics call >> to record statistics > > -1 > > Thanks > -Vincent > >> >> As i said in jira I'm against 3/ >> >> 2/ seems too big for a URL parameter to me and it makes statistics >> depends on URL parameters where 1/ fix the issue without touching >> anything in the statistics module >> >> +1 for 1/ >> +0 for 2/ >> -1 for 3/ >> >> -- >> Thomas Mortagne > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
