On Apr 15, 2010, at 12:56 PM, Sergiu Dumitriu wrote:

> On 04/15/2010 12:55 PM, Caleb James DeLisle wrote:
>> I would like to propose changing checkstyle.xml to allow checkstyle to be 
>> enabled and disabled
>> using inline comments. I propose this with some reservation because this can 
>> be a slippery slope
>> but I would rather see the problems isolated in the file than the file 
>> excluded.
>> Also I think this can be used to enforce checkstyle on changes made to code 
>> in big files in
>> the old core.
> 
> I don't like it very much, since it adds non-code elements in the source 
> file. A source file should contain as little languages as possible, and 
> we already have Java + Javadoc + HTML + English comments, adding 
> checkstyle config would be too much.

I agree with Sergiu.

Thanks
-Vincent

> 
> Can't the error be solved in other ways? What exactly is the problem?
> -- 
> Sergiu Dumitriu
> http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to