Caleb James DeLisle wrote:
> I would like to propose changing checkstyle.xml to allow checkstyle to be 
> enabled and disabled
> using inline comments. I propose this with some reservation because this can 
> be a slippery slope
> but I would rather see the problems isolated in the file than the file 
> excluded.
> Also I think this can be used to enforce checkstyle on changes made to code 
> in big files in
> the old core.

One problem is that you can easily forget about the pieces of code that 
have been excluded from checkstyle. Right now classes that are 
excluded/included from/to checkstyle are listed in the project's pom 
(those that are excluded should have an explanatory comment, as you 
suggested). How can you know which classes still have checkstyle errors 
after they were included in the check list? find/grep on the source tree?

Thanks,
Marius

> 
> WDYT?
> 
> Caleb
> 
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to