Hi, On Tue, Jun 29, 2010 at 4:00 PM, Vincent Massol <[email protected]> wrote:
> Hi Asiri and all, > > On Jun 1, 2010, at 11:28 AM, Asiri Rathnayake wrote: > > > Hi Devs, > > > > I have almost completed my work on officepreview module and I would like > to > > discuss about integrating it into main source tree (and release it with > > 2.4M1). There are a couple of things to discuss: > > > > 1. officepreview module have to depend on xwiki-core for the time being > > because with current component approach there is no way of determining > the > > version of an attachment (officepreview module needs to know attachment > > version). > > Shouldn't we add a DAB method for this? > +1 > > > 2. Need a couple of tests - I'm working on this. > > Asiri, any update on this? > I will have the tests ready by this weekend. On another point, I'll take care of converting OfficePreviewVelocityBridge > to a ScriptService. > > We need a service name. 2 solutions: > > Solution 1: > ========= > $services.office.preview(...) > > This means 3 build modules: > - one for office converter (rename from office import) > - one for office preview > - one for office velocity (for unifying script services between office > converter and office preview). This needs moving > OfficeImporterVelocityBridge to a ScriptService too (which we need to do). > > Solution 2: > ========= > $services.officepreview.preview(....) > + keep using $officeimporter for the office importer > +1 for first solution. Thanks. - Asiri _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
