Hi, > 2. Need a couple of tests - I'm working on this. >> >> Asiri, any update on this? >> > > I will have the tests ready by this weekend. >
I've committed few test cases and also refactored the code a bit (to make it easy to add tests). Let me know if they look ok. Also note that the officepreview macro (which makes it very easy to consume the officepreview service) is located at one of our customer sites [1]. Thanks. - Asiri [1] https://emc.devxwiki.com/xwiki/bin/view/XWiki/OfficePreviewMacro > > > On another point, I'll take care of converting OfficePreviewVelocityBridge >> to a ScriptService. >> >> We need a service name. 2 solutions: >> >> Solution 1: >> ========= >> $services.office.preview(...) >> >> This means 3 build modules: >> - one for office converter (rename from office import) >> - one for office preview >> - one for office velocity (for unifying script services between office >> converter and office preview). This needs moving >> OfficeImporterVelocityBridge to a ScriptService too (which we need to do). >> >> Solution 2: >> ========= >> $services.officepreview.preview(....) >> + keep using $officeimporter for the office importer >> > > +1 for first solution. > > Thanks. > > - Asiri > > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
