On Fri, Sep 3, 2010 at 12:11, Fabio Mancinelli <[email protected]>wrote:
> On 09/02/2010 11:41 PM, Ecaterina Valica wrote: > > On Thu, Sep 2, 2010 at 20:51, Jerome Velociter<[email protected]> wrote: > > > >> Great ! I like it a lot. > >> > >> I think Fabio's remark about the "changed status" being useless > (implied) > >> still holds. Also that user updates should somehow "stand out" compared > to > >> other entries (because it's human content vs. generated updates) that's > why > >> initially I've kept the big double quotes. > >> Anyway those are minor tweaks, I agree with the general idea. > >> > > > > I tried to keep the consistency for all elements, and also to be easy to > > scale for other user events: edit profile, new user or other application > > events: new meeting, new participants, etc. > > > +1. Very nice job! > > Some very minor remarks... It would be nice to rename it to "Recent > activity" (which is a mix between "Recent changes" and "Activity stream" > :)) > Silvia and Gregory once talked about a change it the naming. - if we are gonna support also time filters (since, last month, today, etc. ), then the "Recent" could be changed, - there are not only "changes" since we introduced Applications and User Status Casting, so we can name it the classic "Activity Stream" or like you suggested "Recent Activity" (sounds good). > > Maybe expansion should be triggered either by clicking on the icon, or > one of the avatar pictures or even on the document link (adding a small > arrow to next to it to open the actual document)... Well I don't really > know how to handle this but I've just found that the expasion arrow on > the right is too far. > It's a mess in those classes and I'm no JS expert, so the interaction with the prototype is broken with the latest changes. In the first version, the expand was triggered while clicking on the whole primary item description (ex. "Expense Report: 4 changes by 3 contributors"), not only on the arrow. When the item is expanded, the arrow should change the state. We should also decide what to target on: - avatar: - could be link to user profile OR - link to the expanded view - icon: - could be link to the page (content, attachment, comment, annotation, etc) OR - link to the history entry OR - link to the expanded view Thanks, Caty _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
