On Sun, Jul 10, 2011 at 7:10 PM, Marius Dumitru Florea < [email protected]> wrote:
> Hi James, > > On 07/04/2011 11:11 AM, 许凌志(Jamesxu) wrote: > > Hi, thanks for Marius' help ,last week, I have done the following work: > > (1). Implemented the function that logs a message in the firebug console > > whenever the caret is after [[ > > (2). Implement the function that requests the list of wiki pages > > matching some prefix user input. BUT, don't actually query the database, > > instead simply return a dummy list from the wiki page. > > (3). Implement the function that displays the list of wiki pages where > > the caret is, and integrated it with the SuggestionBox I have already > > implemented. > > > > Here is the plan for next week: > > I will focus on fixing bugs and improving what I have and to make suer > > by the end of the week the link suggest should work very good. Include > > (1). Display the suggestion box in right place and at the right time. > > (2). Close suggestion box in custom, and also when some other keys typed > > like "esc" "right" and "left" > > (3). Test to make sure the prototype for link suggestion runs very well. > > I tested your prototype and here are some of the issues I've found: > > * A JavaScript exception is thrown when you type if the suggest box has > not been displayed at least once > There is no exceptions thrown in the situation you said. Could you give me the content of the exceptions? > > * The close icon is useless, remove it. > I think it is useful for users who want to remove the suggestion box by themselves especially in the situation that some unexcepted exception occured > > * The suggestion box doesn't update its position. If you trigger the > suggest box and then write a long text (try multiple lines) the suggest > box doesn't move. > Yes, it is a problem, I will refine it in this week > > * left/right keys should keep the suggest box open and filter the list > of suggestions > > * Ctrl+Space doesn't work after you close the suggest box by clicking > outside of it. > I think it might not be caused by the suggestion box, I test it in http://www.xwiki.org/xwiki/bin/edit/Main/Support , when you clicking outside of the textarea, Ctrl+Space doesn't work either. > > * Trigger the suggest box, move the mouse over it then type the Tab key > multiple times. The text area looses the focus but the suggest box is > not closed. > Strange, it is ok when I test, type tab key many times, and the suggestion box was closed. > > * The suggest box is triggered by the Delete key. > When Delete key is pressed, it will not send the search request to the server to get the suggestions, but in my design I keep the suggestion open when delete key is pressed, do you think I should close it? > > * The suggest box is not closed by typing ]]. > It is will implemented in this week > > * The suggest box is not closed by deleting [[. > yes, it is a problem, I will refine it this week > > * Ctrl+Space should be ignored if the suggest box is already displayed > yes, it is true, I will refine it this week > > * You don't take into account Undo/Redo operations nor the paste event. > Yes, I will consider it later. > > * The suggest box should be displayed were there is space. If the caret > is close to the bottom of the window and the suggest box doesn't fit > below the caret then it should be displayed above. Same with left/right. > Ok, I will consider it, but I think it is not a critical problem, because the suggestion box is not so big, so I think it is ok if it overflows the editor area a bit > > For the next week I think you should: > > (1) retrieve real suggestions using REST > (2) generate the link syntax when a suggestion is selected > (3) fix some of the issues I've listed above > > Thanks, > Marius > > > > > -- > > Best wishes, > > > > 许凌志(Jame Xu) > > > > MOE KLINNS Lab and SKLMS Lab, Xi'an Jiaotong University > > > > Department of Computer Science and Technology, Xi’an Jiaotong University > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Best wishes, 许凌志(Jame Xu) MOE KLINNS Lab and SKLMS Lab, Xi'an Jiaotong University Department of Computer Science and Technology, Xi’an Jiaotong University _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
