Hi James,

On 07/17/2011 09:38 AM, 许凌志(Jamesxu) wrote:
> 2011/7/17 许凌志(Jamesxu)<[email protected]>
>
>>
>>
>> On Sun, Jul 10, 2011 at 7:10 PM, Marius Dumitru Florea<
>> [email protected]>  wrote:
>>
>>> Hi James,
>>>
>>> On 07/04/2011 11:11 AM, 许凌志(Jamesxu) wrote:
>>>> Hi, thanks for Marius' help ,last week, I have done the following work:
>>>> (1). Implemented the function that logs a message in the firebug console
>>>> whenever the caret is after [[
>>>> (2). Implement the function that requests the list of wiki pages
>>>> matching some prefix user input. BUT, don't actually query the database,
>>>> instead simply return a dummy list from the wiki page.
>>>> (3). Implement the function that displays the list of wiki pages where
>>>> the caret is, and integrated it with the SuggestionBox I have already
>>>> implemented.
>>>>
>>>> Here is the plan for next week:
>>>> I will focus on fixing bugs and improving what I have and to make suer
>>>> by the end of the week the link suggest should work very good. Include
>>>> (1). Display the suggestion box in right place and at the right time.
>>>> (2). Close suggestion box in custom, and also when some other keys typed
>>>> like "esc" "right" and "left"
>>>> (3). Test to make sure the prototype for link suggestion runs very well.
>>>
>>> I tested your prototype and here are some of the issues I've found:
>>>
>>> * A JavaScript exception is thrown when you type if the suggest box has
>>> not been displayed at least once
>>>
>> I have refine it, it works fine now.
>>
>>
>>>
>>> * The close icon is useless, remove it.
>>>
>> I have deleted it, user still can use "ESC" to close the suggestion box
>>
>>>
>>> * The suggestion box doesn't update its position. If you trigger the
>>> suggest box and then write a long text (try multiple lines) the suggest
>>> box doesn't move.
>>>
>> The suggestion box will update its position when user are typing now.
>>
>>
>>>
>>> * left/right keys should keep the suggest box open and filter the list
>>> of suggestions
>>>
>>
>> *I have test the eclipse and also dreamweaver, when the left/right keys
>> are typed, the suggestion box is closed, I think it is easy, it is intuitive
>> that user move the caret do not want to get suggestion results, instead it
>> is very possible to add something or refine something he has already typed
>> before. *
>>

> I have tested again, in eclipse, when left and right key typed, the
> suggestion box stay open,and the suggestions are filtered
> but in dreamweaver, when left/right key is pressed, the suggestion box is
> closed.
> So which behaviour should we implement, eclipse way or dreamweaver way, I
> prefer dreamweaver way.

I prefer the Eclipse behaviour, but you can leave this for later.

>
>>
>>> * Ctrl+Space doesn't work after you close the suggest box by clicking
>>> outside of it.
>>>
>>
>> *As we discuss last week, I think it is a complicated function that we
>> have to consider the whole context of the suggestion process, till now, I
>> only consider the trigger "[[", in the context of "[[" there might be other
>> sub-triggers, like "attach:","@", ".", "||", when user type Ctrl+space at
>> different sub-context of the triggers, the query behaviour will be
>> different, it is a bit complex, and I need more time to design, implement
>> and test it, so I will left it to next week. *
>>
>>>
>>> * Trigger the suggest box, move the mouse over it then type the Tab key
>>> multiple times. The text area looses the focus but the suggest box is
>>> not closed.
>>>
>>
>> It is refined now ,you can test it.
>>
>>>
>>> * The suggest box is triggered by the Delete key.
>>>

>> *It is easy to close the suggestion box when user type Backspace key,
>> however, I have tested eclipse and also dreamweaver, when user types
>> backspace key, the suggestion box will not be closed, and the suggestion
>> result will still be updated.
>> *

The problem is not that Backspace _leaves_ the suggest box open. This is 
fine. The problem was that you could _open_ the suggest box by typing 
Backspace after [[text.

>>
>>>
>>> * The suggest box is not closed by typing ]].
>>>
>> It is ok now, when user types ]], and then the suggestion box will be
>> closed.
>>
>>>
>>> * The suggest box is not closed by deleting [[.
>>>
>>
>> It is okn now ,when user delete [[, the suggestion box will be closed.
>>
>>>
>>> * Ctrl+Space should be ignored if the suggest box is already displayed
>>>
>>
>> *I will consider Ctrl+space later.  *
>>
>>>
>>> * You don't take into account Undo/Redo operations nor the paste event.
>>>
>>
>> *I will consider it later. *
>>
>>>
>>> For the next week I think you should:
>>>
>>> (1) retrieve real suggestions using REST
>>>
>>
>> I have read the document of how to write rest sevice, but I need to discuss
>> with you more about how to do it, so I think we can discuss this next week
>>
>>> (2) generate the link syntax when a suggestion is selected
>>>
>> it is finished
>>
>>> (3) fix some of the issues I've listed above
>>>
>> I have finished most of the issues you've listed above, only this I need to
>> think more and have further discussion with you.
>> a.ctrl+space related functions. (I will consider it next week)
>> b.undo/redo/paste related functions(I will consider it next few weeks)
>> c.Adaptive suggestion box. (later, less important)

Sounds good.

Thanks,
Marius

>>
>>>
>>> Thanks,
>>> Marius
>>>
>>>>
>>>> --
>>>> Best wishes,
>>>>
>>>> 许凌志(Jame Xu)
>>>>
>>>> MOE KLINNS Lab and SKLMS Lab, Xi'an Jiaotong University
>>>>
>>>> Department of Computer Science and Technology, Xi’an Jiaotong University
>>> _______________________________________________
>>> devs mailing list
>>> [email protected]
>>> http://lists.xwiki.org/mailman/listinfo/devs
>>>
>>
>>
>>
>> --
>> Best wishes,
>>
>> 许凌志(Jame Xu)
>>
>> MOE KLINNS Lab and SKLMS Lab, Xi'an Jiaotong University
>>
>> Department of Computer Science and Technology, Xi’an Jiaotong University
>>
>
>
>
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to