On Fri, Sep 2, 2011 at 9:06 AM, Vincent Massol <[email protected]> wrote: > > On Sep 2, 2011, at 8:52 AM, Thomas Mortagne wrote: > >> Hi devs, >> >> I started to move (very) old notification system to legacy > > I've seen this: very nice! > >> but I'm >> stuck because there is one thing still not supported by new >> observation system: event sent before executing an action. >> >> So here it is: I propose to add it with the name ActionExecutingEvent >> in the bridge. > > I'm not sure if the model bridge module is the right place. Right now it > contains some event classes but they are events related to Model entities. > > We could put this temporary class in the oldcore. I call it temporary since > it will be replaced in the future with the new Action module.
Actually I did wanted to put it in oldcore at first but it will make a migration nightmare for anyone that used to use ActionExecutionEvent without depending on oldcore. Bridge is ok since ActionExecutionEvent has exactly the same parameters that document related events which are readable in most part with bridge APIs. > >> At the same time I would also like to come with ActionExecutedEvent in >> the bridge to replace the ActionExecuteEvent which is currently in >> observation API (and that should never have been there). > > +1 to remove that event from the observation api since it's definitely not > the place. > > I'd not put this new event class in the bridge for the same reason as above. > I'd put it next to the other one. > > Thanks > -Vincent > >> WDYT ? >> >> here is my +1 >> >> -- >> Thomas Mortagne > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
