On Fri, Sep 2, 2011 at 9:21 AM, Sergiu Dumitriu <[email protected]> wrote: > On 09/02/2011 03:15 AM, Thomas Mortagne wrote: >> On Fri, Sep 2, 2011 at 9:11 AM, Sergiu Dumitriu<[email protected]> wrote: >>> On 09/02/2011 02:52 AM, Thomas Mortagne wrote: >>>> Hi devs, >>>> >>>> I started to move (very) old notification system to legacy but I'm >>>> stuck because there is one thing still not supported by new >>>> observation system: event sent before executing an action. >>>> >>>> So here it is: I propose to add it with the name ActionExecutingEvent >>>> in the bridge. >>> >>> -1 for the bridge, unless we rename it from model-bridge to >>> oldcore-bridge, since it actually bridges the connection between >>> components and the oldcore. Initially it was supposed to be a mockup of >>> the future model component only, but it looks like it's far from it. >>> >>>> At the same time I would also like to come with ActionExecutedEvent in >>>> the bridge to replace the ActionExecuteEvent which is currently in >>>> observation API (and that should never have been there). >>> >>> +1. >>> >>>> WDYT ? >>>> >>>> here is my +1 >>> >>> +1. >>> >>> I think they should also be cancellable, blocking requests if they fail >>> some conditions. >> >> Sure why not, I will also make them implements BeginEvent/EndEvent >> interfaces. > > Hm, then if something blocks the execution by canceling the event, will > the matching EndEvent be fired? Will it be a problem if a BeginEvent > with no EndEvent is fired?
ActionExecutionEvent is already sent in a finally so that should be ok. In any case for this particular use case that would not be a big issue I think since the event stack is stored in the ExecutionContext and there is not much code executed after an action is executed generally. > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
