+1 provided we address the backward compatibility issue raised by Vincent. Thanks, Marius
On Thu, Jan 12, 2012 at 8:54 AM, Vincent Massol <[email protected]> wrote: > Hi Caty, > > On Jan 11, 2012, at 5:30 PM, Ecaterina Moraru (Valica) wrote: > >> Hi devs, >> >> Since the recent Skin/ColorThemes changes done for XE 3.4, the existing >> ColorThemes are deprecated. >> I propose to remove them from our standard distribution and replace them >> with some themes created specially for the new skin changes. >> You can see these 3 new colorthemes (Ruby, Dusk, Mint) at: >> http://incubator.myxwiki.org/xwiki/bin/view/Improvements/34NewColorThemes >> (clicking on the preview image you can see them in action) >> obs. I created a ColorTheme for every color we have in XWiki logo (blue, >> orange, red, green) >> >> The deprecated ColorThemes will still be available in the extensions >> repository: >> Default >> http://extensions.xwiki.org/xwiki/bin/view/Extension/Default33+ColorTheme >> Bordo http://extensions.xwiki.org/xwiki/bin/view/Extension/Bordo+ColorTheme >> Nature >> http://extensions.xwiki.org/xwiki/bin/view/Extension/Nature+ColorTheme >> BlueSky >> http://extensions.xwiki.org/xwiki/bin/view/Extension/BlueSky+ColorTheme >> Inner Dark >> http://extensions.xwiki.org/xwiki/bin/view/Extension/Inner+Dark+ColorTheme >> Nightfall >> http://extensions.xwiki.org/xwiki/bin/view/Extension/Nightfall+ColorTheme >> Peach http://extensions.xwiki.org/xwiki/bin/view/Extension/Peach+ColorTheme >> >> This is my +1 >> >> Pull request at >> https://github.com/xwiki/xwiki-enterprise/pull/14 >> waiting for the vote result and will be committed for 3.4 RC1. > > +1 > > I've commented on the issue (I saw it before seeing this thread). I'm copy > -pasting what I mentioned there: > > * Didn't we agree to name the 3.3 color theme with a name instead of > Default33? > * What happens if a user was using one of those color themes in 3.3 and > upgrades to 3.4? His color themes won't be found (not sure what color theme > will be used in this case - the new default one?). So it means we agree to > break the user. It also means that the minimum we should do it make sure to > document this in the Release Notes to explain how to get back his theme. > > Thanks > -Vincent > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
