@Vincent: * I understood that we would rename the old default theme if we would have kept it in the distribution. At first I wanted to transform it to align with the changes and give it a new name. Since I removed it the only renaming step left would be the name of extension. Right now what is on extensions is exactly the state of the theme before 3.4 - ColorThemes.DefaultColorTheme. We could rename it OR leave it original and act like a revert/reset point. If we will rename it, the new name would have no particular meaning for the users (since they know it by the old/default name).
* When a theme has been removed, the variables that will be applied are from the fallback theme (the complete gray one). If he used the Default33, we will see the variables from the new Default. If we had a custom theme (not from the themes that were bundled) he will see it, but the look will be messed up (since the skin had changed). The solution will be to align his custom theme with the new changes or revert/add the skin to accommodate the particular style. @Sergiu: are you referring to rename the new "Default Color Theme" into something else? We could do that. The only problem is the one raised by Vincent, when a user is doing an upgrade he will need to manually set the new default (if that is what he was using) to the newNameTheme. IMO, we have a theme called "Default Color Theme" in order to differentiate it from the others and because we are doing the majority of the test and screenshots with it. Thanks all, Caty On Thu, Jan 12, 2012 at 10:09, Marius Dumitru Florea < [email protected]> wrote: > +1 provided we address the backward compatibility issue raised by Vincent. > > Thanks, > Marius > > On Thu, Jan 12, 2012 at 8:54 AM, Vincent Massol <[email protected]> > wrote: > > Hi Caty, > > > > On Jan 11, 2012, at 5:30 PM, Ecaterina Moraru (Valica) wrote: > > > >> Hi devs, > >> > >> Since the recent Skin/ColorThemes changes done for XE 3.4, the existing > >> ColorThemes are deprecated. > >> I propose to remove them from our standard distribution and replace them > >> with some themes created specially for the new skin changes. > >> You can see these 3 new colorthemes (Ruby, Dusk, Mint) at: > >> > http://incubator.myxwiki.org/xwiki/bin/view/Improvements/34NewColorThemes > >> (clicking on the preview image you can see them in action) > >> obs. I created a ColorTheme for every color we have in XWiki logo (blue, > >> orange, red, green) > >> > >> The deprecated ColorThemes will still be available in the extensions > >> repository: > >> Default > >> > http://extensions.xwiki.org/xwiki/bin/view/Extension/Default33+ColorTheme > >> Bordo > http://extensions.xwiki.org/xwiki/bin/view/Extension/Bordo+ColorTheme > >> Nature > >> http://extensions.xwiki.org/xwiki/bin/view/Extension/Nature+ColorTheme > >> BlueSky > >> http://extensions.xwiki.org/xwiki/bin/view/Extension/BlueSky+ColorTheme > >> Inner Dark > >> > http://extensions.xwiki.org/xwiki/bin/view/Extension/Inner+Dark+ColorTheme > >> Nightfall > >> > http://extensions.xwiki.org/xwiki/bin/view/Extension/Nightfall+ColorTheme > >> Peach > http://extensions.xwiki.org/xwiki/bin/view/Extension/Peach+ColorTheme > >> > >> This is my +1 > >> > >> Pull request at > >> https://github.com/xwiki/xwiki-enterprise/pull/14 > >> waiting for the vote result and will be committed for 3.4 RC1. > > > > +1 > > > > I've commented on the issue (I saw it before seeing this thread). I'm > copy -pasting what I mentioned there: > > > > * Didn't we agree to name the 3.3 color theme with a name instead of > Default33? > > * What happens if a user was using one of those color themes in 3.3 and > upgrades to 3.4? His color themes won't be found (not sure what color theme > will be used in this case - the new default one?). So it means we agree to > break the user. It also means that the minimum we should do it make sure to > document this in the Release Notes to explain how to get back his theme. > > > > Thanks > > -Vincent > > > > _______________________________________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
