On Wed, Feb 29, 2012 at 8:47 PM, Eduard Moraru <[email protected]> wrote: > Hi Marius, > > I have updated the pull request based on your comments.
+1 then :) Thanks, Marius > > Thanks, > Eduard > > On Wed, Feb 29, 2012 at 8:54 AM, Marius Dumitru Florea < > [email protected]> wrote: > >> I commented on the pull request. I'm waiting for your replies before >> casting my vote. >> >> Thanks, >> Marius >> >> On Tue, Feb 28, 2012 at 2:53 PM, Eduard Moraru <[email protected]> >> wrote: >> > Hi devs, >> > >> > As you know from the previous discussion [1], I`ve worked on integrating >> > the work done by Anca to merge Annotations with Comments. >> > >> > I`ve fixed leftover integration problems and finished implementing the >> > migration script. >> > >> > Please have a look at the pull request [2] and cast your vote whether we >> > can merge it into master for 4.0 or not. >> > >> > Here's my +1. >> > >> > Thanks, >> > Eduard >> > >> > ---------- >> > [1] http://markmail.org/thread/gecez5hdh5eci2le >> > [2] https://github.com/xwiki/xwiki-platform/pull/34/files >> > _______________________________________________ >> > devs mailing list >> > [email protected] >> > http://lists.xwiki.org/mailman/listinfo/devs >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
