On Fri, Mar 2, 2012 at 13:19, Anca Luca <[email protected]> wrote: > On 02/28/2012 01:53 PM, Eduard Moraru wrote: > >> Hi devs, >> >> As you know from the previous discussion [1], I`ve worked on integrating >> the work done by Anca to merge Annotations with Comments. >> >> I`ve fixed leftover integration problems and finished implementing the >> migration script. >> >> Please have a look at the pull request [2] and cast your vote whether we >> can merge it into master for 4.0 or not. >> > > I commented too, otherwise looks fine to me. > I didn't read the migrator though, I'll leave that to the puller. >
I just have a look at the migrator and made some comments. I have not followed closely the task, but I have the impression that the migration could be done per document and not as a whole like you do which execute the whole migration in a single transaction that could be really heavy on the DB side. This is not failsafe, and could cause many annoying issue if it goes wrong due to the transaction size. So, except if there is a good reason I have missed, the migration should at least be splitted in smaller transactions, one per document seems easy. In such implementation, restarting after failure would normally continue the job where it have been left. > > Thanks, > Anca > > > >> Here's my +1. >> >> Thanks, >> Eduard >> >> ---------- >> [1] >> http://markmail.org/thread/**gecez5hdh5eci2le<http://markmail.org/thread/gecez5hdh5eci2le> >> [2] >> https://github.com/xwiki/**xwiki-platform/pull/34/files<https://github.com/xwiki/xwiki-platform/pull/34/files> >> ______________________________**_________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs> >> > > ______________________________**_________________ > devs mailing list > [email protected] > http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs> > -- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
