On Thu, Jun 28, 2012 at 2:43 PM, Vincent Massol <[email protected]> wrote: > > On Jun 28, 2012, at 2:31 PM, Thomas Mortagne wrote: > >> On Thu, Jun 28, 2012 at 2:19 PM, Vincent Massol <[email protected]> wrote: >>> Hi devs and Thomas, >>> >>> Just noticed a new commons-repository module. >>> >>> Could someone explain to me what is this new module and why it's not part >>> of xwiki-commons-extension, even though it's full of references to >>> "extension" everywhere in it? (109 occurrences) >> >> Since Extension Manager as an module to install/manage extension in > > has? > is? > >> your application and XWiki Repository as a platform to distribute > > has? > is? > >> extensions are very different technically and are starting to be >> pretty big Marius and me decided to separated them in two different >> modules. The main link between them is that Extension Manager has a >> handler for this kind of repositories exactly like it has one for >> maven repositories (and more later). It makes easier to manage them >> separately in UI tests, Jira,etc. > > Sorry but I don't really understand what you mean. > > Can you give me a use case where someone would use commons-repository alone > (without xwiki-extension)?
* any client for which the purpose is not to install extensions (a mobile client for XWiki Repository, etc.) * any client which has its own local extension management system and which to add support for other kind of repositories (like we have support for maven repositories etc. ourself) * another implementation of the protocol (a plugin for Nexus for example) XWiki based implementation of XWiki Repository itself does really use Extension Manager right now except for importing an extension coming from another repository but this is a feature and not really the hearth of XWiki Repository. Things go directly from document to REST. As I said technically there are completely separated. > > I don't understand why it's a problem to have > xwiki-commons-extension/xwiki-commons-extension-repository/ and what it > changes for ui tests, jira, etc > > I also see we have > xwiki-commons-extension/xwiki-commons-extension-repositories/ what are those > compared to xwiki-commons-repository? This folder contains repository handlers. That's what convert EM API into various actual repositories protocols (Maven, XR, etc.). > > Also xwiki-commons-repository-api is pretty empty… It has a class which is > about REST and which should probably be in a REST module and there's another > one which is an interface with no methods. You are just looking at the number of classes. Resources class define the whole repository protocol and is required by any client or server. Also it's just a start, if we have other helpers for clients/servers of this protocol they will go there. You complain this module and too small and you want to create a new REST module with half of it ? I tough it was not worthing it. > > I really don't see the point of a separate top module in commons. I'm > probably missing something. > > Thanks > -Vincent > >>> Note1: Its description in pom.xml is pretty vague: >>> <description>XWiki Commons - Repository</description> >>> In commons-repository-api it's even worse: >>> <description>Contains commons stuff to use in a a client or a server >>> implementation</description> >>> >>> Note2: On http://commons.xwiki.org/xwiki/bin/view/Main/WebHome it's not >>> described either, nor on e.x.o >> >> I just finished the refactoring on git yesterday... >> >>> >>> Thanks >>> -Vincent >>> >>> _______________________________________________ >>> devs mailing list >>> [email protected] >>> http://lists.xwiki.org/mailman/listinfo/devs >> >> >> >> -- >> Thomas Mortagne >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
