On 08/08/2012 10:57 AM, Guillaume Lerouge wrote:
Hi Jonathan,
please see my answers below.
On Tue, Aug 7, 2012 at 8:38 PM, Jonathan Solichin <[email protected]>wrote:
Hi Guillaume,
Thanks for dropping by. You are right, the feature is part of XWiki; the
skin is just now implemented to take advantage of it.
The reason I wanted to create a specific configuration page for the skin on
top of this is because some of the features/color styling that are in the
original skin are not part of XWiki's color theme. Eg. rgba color coding
(allows for changes in opacity), and h1-h6 color differentiation etc. Some
of the color themes available through xwiki are not very relevant to the
skin either. Eg. Gradients and so forth.
In that case the right solution would be to extend the color theme
mechanism in order for it to offer the additional values you need, not
adding a new configuration page :-)
I'm not so sure about that. Extending the official color theme
application is going to be a PITA for maintenance over the long term for
any skin not bundled and supported by the XWiki dev team.
It's one thing to use the color theme mechanism for preferences storage
of new skin-specific properties (but even that in my opinion doesn't
worth it) ; but extending the UI for managing those preferences is
another and I don't see that a viable solution right now.
Jerome
Guillaume
The other option is to use all the colors on XWiki color theme, but it
might not be named correctly (eg. using button's 2nd gradient color as the
color for h4).
Let me know if that sort of addresses your concern, or whether you still
think there is a better way to go about this.
Thanks again!
Jonathan Solichin
On Tue, Aug 7, 2012 at 1:21 AM, Jonathan Solichin <[email protected]
wrote:
Hello friends,
I just updated the skin to allow the use of xwiki built in color themes.
My plan is to have a settings page that allows you to use xwiki color
themes, or use a preset color theme specifically made for xorange (eg.
the
original one + maybe a couple more).
Beside this major change, most of the fixes mentioned earlier are
implemented (eg. blog skin and other miscellaneous fixes/skin
improvements
(js, responsiveness etc.)).
I am still working on separating the core skin with the extra portion.
I'm
still not sure of what part people might change, so I don't know where I
should draw the line. Any thoughts on this would be appreciated.
Thanks again everyone,
Jonathan Solichin
On Thu, Aug 2, 2012 at 1:29 AM, Jonathan Solichin <[email protected]
wrote:
Hello friends,
Beside yesterday's addition, these have also been addressed. I apologize
if you checked yesterday and the addition was not on github/live
instance,
I uploaded the unchanged folder.
- Lots of sections in Administration are missing the styles + some
portion
of settings are displayed after the administration menu ends (Chrome)
(you
need to scroll in order to see all the options, see Administration ->
Applications -> WYSIWYG Editor settings )
- .xform style for .xHint are gone (you can observe this when creating
pages/spaces)
I just uploaded some stylings that makes this more eye pleasing and
responsive.
- The page -> Share by email feature is style-less.
Styled this as well
Thank you,
Jonathan Solichin
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
--
Peace,
—Jerome
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
