Hello Jerome, Caty, First thank you again for the continual guidance.
> This is an area I can help you test, I actually have already started > implementing my own skin that derives xorange. If I may ask, what parts of the skin are you editing/deriving. It might help to see what part people want to change. After I logged in I really don't know what button to press in order to edit > the Main.WebHome. Apologies, I disabled that and forgot to turn it back on. Regarding the buttons (Preview, Save&View, Save&Continue, etc.), I see that > you choose to align them right. Our standard is vertical-aligned-left > http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms > I notice this on login page and on editing pages. This is easily fixable > from CSS (.buttons class). > I think this ought to be skin specific. I take the standard as for the > officially maintained XE skin, a.k.a. colibri ; and think it would be > fair to say other skins could derive from it. > That said, I have a personnal preference for left-aligned or centered > buttons. Thank you for bringing this to my attention. I have changed it to left aligned now. > You stripped all the CSS, so there will be lots of problems in lots of > > places. Maybe you should put back all the style dependencies. > I think Jonathan took inspiration from me on this one, this is what I've > done in Lyrebird. > To be honest, I think that pulling all style dependencies for > implementing a new skin is at least as hard as rewritting them all. Lots > of "component styles" (ex. search suggest, livetable, etc.) are in > reality tied to the visual codes of colibri (and sometimes even the > selectors are tied to colibri), and don't work well outside this scope. > The long term solution would be to have documented CSS components (a la > bootstrap for example) and DOM breakpoints (i.e. #mainContentArea, etc. > - this would also be useful in the event we implement generic interface > extensions as they were initially planned). > Now, there are some styles that could be pulled or copied over from > colibri. {{code}} macro styles are one example, but I'm sure there are > others. I agree it is a really big task. I was inspired by your lyrebird here. I was wondering whether I should keep the default style. You can see that I left some of the default styling at the bottom of my xwiki.css. One of the hopes that I had to asking for other's input now that the majority of the skin is finished, was to help me hunt down what I am missing (so thanks for that). Presently I am hoping to style as much as I can/copy the unstyled/derive, but maybe it is too big of a task, and I'll add in the original css(s). The style for info is not noticeable enough(looks very similar to table > headers). The style used for warning is better suited for error macro. Hmm, i was trying to keep it at a neutral color and keeping to the color scheme of the skin (you're right it is the same color as the table header). I was hoping that the fact that it goes beyond the padding of the rest of content, and it's different background color would be visible enough yet not distracting. Maybe if I add an icon (like back during the mockup) it would help. And you're right, that is the wrong color choice, I fixed that issue. Right now it is: gray for info, pale yellow for warning, and pale red for error. I will play around with this. > > - Administration -> ColorThemes can't be edited anymore in inline mode > (the > > JS doesn't work) > > - Administration -> Panel Wizard is broken too > > - Administration -> Users, Groups (adding, editing, deleting > users/groups) > > doesn't work > JS issue ? I think JSX are puled by xorange. Maybe there is a conflict > with other JS code from xorange... you're right, it was a js conflict, thank you. I am not sure exactly which one, but all these functions now work. xorange's startpage.vm is now derived of colibri as well. - Some more left-right margins on content would be nice (looks crowded). > 25px+ would work better than 10px margins on #xo-content I implemented a 30px padding now, but I am not sure how I feel about it. I feel like it throws the skin of balance. Let me know if the change I made is what you expected. Maybe someone can add more input on this? I am definitely open to experimenting though, maybe I just need to get used to it. > - I like the Administration breadcrumb :p Thank you. - I like how some forms look in edit mode :) like editing the Profile, > although there are some issues with the sections H1 > - Lots of sections in Administration are missing the styles + some portion > of settings are displayed after the administration menu ends (Chrome) (you > need to scroll in order to see all the options, see Administration -> > Applications -> WYSIWYG Editor settings ) That is very interesting. I think these two points go hand in hand. I made the form label float to the left of the text for styling purposes, which causes issue when the label is too long (eg. the WYSIWYG editor setting). It's going to be interesting to see if I can mediate between the two. All the areas I did not address here, will be addressed soon. Thank you again for helping me. And I would like to also say thanks for dropping by Caty. Best, Jonathan Solichin On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin <[email protected]>wrote: > I think that's a great idea, it would make the skin more extensible. Right > now I am exploring creating a xar to create a page where there can be > options-- right now for the colors, like you did with the "fluid" option on > lyrebird. > > As I am separating the codes, i am wondering how far i should separate the > core? Should i just leave enough css that there is a sidebar, the header, > and the main content area? > > Thank you, > Jonathan Solichin > > On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin <[email protected] > > wrote: > >> I think that's a great idea, it would make the skin more extensible. >> Right now I am exploring creating a xar to create a page where there can be >> options-- right now for the colors, like you did with the "fluid" option on >> lyrebird. >> >> As I am separating the codes, i am wondering how far i should separate >> the core? Should i just leave enough css that there is a sidebar, the >> header, and the main content area? >> >> Thank you, >> Jonathan Solichin >> >> >> On Thu, Jul 26, 2012 at 1:42 AM, Jonathan Solichin >> <[email protected]>wrote: >> >>> Hi Jerome, >>> >>> All the advise you mentioned should now be fixed on github. Ajax search >>> is now implemented. >>> >>> I will be working on color themes, while still trying to ensure >>> consistency through out XE UI. >>> >>> Thank you again! >>> Jonathan Solichin >>> >>> >>> On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin < >>> [email protected]> wrote: >>> >>>> Hello Friends, >>>> >>>> As you may or may not know, I have been working on a responsive skin >>>> for XWiki for GSOC ( >>>> http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome). As I continue >>>> to add further details and refinements into the skin, I would like to >>>> kindly ask for your help in doing so. In order to make sure that I did not >>>> miss anything and the skin is as complete as possible, I would like to, if >>>> possible, request a XAR of an existing wiki (or complex pages) so that I >>>> may see the result of implementing the skin on more than the default wiki >>>> data. >>>> >>>> If this is not a possible, I would like to still enlist your help in >>>> testing some basic/your favorite functionality/features of xwiki. There are >>>> several ways to do this: >>>> >>>> - By downloading the current skin and testing it on your XWiki: >>>> https://github.com/jssolichin/xo5 >>>> - By playing around with the live instance (uses default admin >>>> user/password): http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome >>>> - By letting me know of your favorite applications (so that I may >>>> look into implementing them) >>>> >>>> Anything you want to note is fine. Bug and feature request are both >>>> welcome, as I think communal ideas are often better than one. Even if you >>>> did not have a chance to play too much with the skin, go ahead and let me >>>> know what you think I should check on (based on your experience) and/or >>>> give me any suggestions that may have come up while reading this. >>>> Technicality permitting, I will check myself. >>>> >>>> Helping with this process will help make the skin better, and maybe >>>> help it to be tailored to your (/type of) wiki and the community >>>> surrounding the platform in general. >>>> >>>> Thank you in advance for your time! >>>> Jonathan Solichin >>>> >>> >>> >> > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
