Actually, after starting the move on my computer and more thinking, I don't think we can do this now.
Technically there's no issue, we could move the events to the model module. The problem is a problem of what will happen in the future. Right now in the locations where we send the events, we pass XWikiDocument and XWikiContext as parameters to notify() and the receivers are *expecting* to receive them. In the future we'll want to pass a new model object for the document. When we do this, even though the event classes won't need to change a bit, all listeners will be broken if the senders continue to send the same events with different values. Thus we'll need new events when we do this to not break backward compatibility… And thus it's better to keep the model namespace free for when we'll have the new model… I'm thus removing this proposal. Thanks -Vincent On May 11, 2013, at 4:48 PM, Vincent Massol <[email protected]> wrote: > Hi devs, > > I'd like to copy all Document*Event in > xwiki-platform-model/src/main/java/org/xwiki/model/event/* and deprecate > (move to legacy) all the ones in the bridge module. > > It seems they don't need XWikiContext, XWikiDocument or the like so it should > be pretty easy. > > WDYT? > > Thanks > -Vincent > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
