On May 13, 2013, at 8:41 AM, Thomas Mortagne <[email protected]> wrote:
> I would have voted -1 anyway, I insisted for this event to not be in > the model module the first time for a reason… Sure and I read that email thread about 10 times slowly but since you didn't explain why precisely, I didn't understand… Which is why I took the time to explain it below (which would have saved me several hours if you had in your first email ;)). Precisely you said "we can't move them to model module since theses events still send XWikiContext and XWikiDocument" which is obviously not correct. These events do not use XWikiContext nor XWikiDocument… It's the code that sends those events that use them and we can't move them *because* we don't want to reserve the namespace so that it's available the future… Not that obvious to figure out for my stupid brain… :) Sorry not to be more intelligent... I've now created http://jira.xwiki.org/browse/XWIKI-9137 to remember it. Thanks -Vincent > On Sun, May 12, 2013 at 8:37 AM, Vincent Massol <[email protected]> wrote: >> Actually, after starting the move on my computer and more thinking, I don't >> think we can do this now. >> >> Technically there's no issue, we could move the events to the model module. >> >> The problem is a problem of what will happen in the future. Right now in the >> locations where we send the events, we pass XWikiDocument and XWikiContext >> as parameters to notify() and the receivers are *expecting* to receive them. >> In the future we'll want to pass a new model object for the document. When >> we do this, even though the event classes won't need to change a bit, all >> listeners will be broken if the senders continue to send the same events >> with different values. Thus we'll need new events when we do this to not >> break backward compatibility… >> >> And thus it's better to keep the model namespace free for when we'll have >> the new model… >> >> I'm thus removing this proposal. >> >> Thanks >> -Vincent >> >> >> On May 11, 2013, at 4:48 PM, Vincent Massol <[email protected]> wrote: >> >>> Hi devs, >>> >>> I'd like to copy all Document*Event in >>> xwiki-platform-model/src/main/java/org/xwiki/model/event/* and deprecate >>> (move to legacy) all the ones in the bridge module. >>> >>> It seems they don't need XWikiContext, XWikiDocument or the like so it >>> should be pretty easy. >>> >>> WDYT? >>> >>> Thanks >>> -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
