On Fri, May 17, 2013 at 11:36 AM, Thomas Mortagne <[email protected] > wrote:
> I checked and the real issue is that this is half implemented so we > just need to fix it. > Do we know how it goes through the testing without being noticed ? > > On Fri, May 17, 2013 at 9:15 AM, Thomas Mortagne > <[email protected]> wrote: > > #-# [Since 5.0M2] > > #-# What to do when the requested wiki does not exist: > > #-# - 0: (default) serve the main wiki > > #-# - 1: display an error (customizable through wikidoesnotexist.vm or > > xwiki:XWiki.WikiDoesNotExist) > > # xwiki.virtual.failOnWikiDoesNotExist=0 > > > > So the option do exist. > > > > On Fri, May 17, 2013 at 9:14 AM, Thomas Mortagne > > <[email protected]> wrote: > >> Something already been decided to take care of this issue: by default > >> when your wiki cannot be found you are supposed to fallback on main > >> wiki. > >> > >> Maybe Edy did not had time to finish it but I'm pretty sure I see the > >> option about it in the xwiki.cfg.vm. > >> > >> On Fri, May 17, 2013 at 8:49 AM, Vincent Massol <[email protected]> > wrote: > >>> Hi Denis and all, > >>> > >>> On May 17, 2013, at 12:20 AM, Denis Gervalle <[email protected]> wrote: > >>> > >>>> Hi Vincent, > >>>> > >>>> > >>>> On Thu, May 16, 2013 at 10:05 PM, Vincent Massol <[email protected]> > wrote: > >>>> > >>>>> Hi devs, > >>>>> > >>>>> Now that the virtual mode is on by default our users are having > troubles > >>>>> when they install 5.0.1. > >>>>> It's the second time in 2 days that I have to help someone. > >>>>> > >>>>> The issue is that users will want to use URLs such: > >>>>> http://myhost/xwiki/bin/view/Main/WebHome > >>>>> > >>>>> And those URLs don't work anymore by default (which can be seen as a > >>>>> regression). > >>>>> > >>>>> So I'm proposing the following change for 5.0.2/5.1M1: > >>>>> * If there's only 1 wiki configured then always point to the main > wiki. > >>>>> > >>>>> WDYT? > >>>>> > >>>> > >>>> This has already been discussed. I was in favor of that behavior, but > >>>> Edouard mention a potential confusing example in: > >>>> http://markmail.org/message/ggjgqlfubjfyfxto > >>>> > >>>> So, what has been decided is to provide a more explicit message, and > what I > >>>> have suggested is to have an easy way for an admin to create the > missing > >>>> server descriptor when that error occurs. > >>>> > >>>> You should read the thread about this change in detail before > proposing a > >>>> new solution. > >>> > >>> Thanks for pointing me to this thread which I hadn't read at the time. > >>> > >>> I've now read it and I see that nothing was done on this point that > you raised (as item 3) in that thread). Eduard said that it could be a > problem for someone having 2 wikis and removing 1 and then all URLs would > redirect to that main wiki instead of noticing that the wiki he's pointing > to has been removed. > >>> > >>> The difference with now and when that thread was written is the > feedback we're getting from users trying XWiki 5.0+. We already have some > user who have stopped using XWiki because they found it too complex to > setup with this new virtual on by default and some others who spent hours > scratching their heads to figure out why something worked before and is no > longer working. > >>> > >>> So I really think we need to do something and quite fast (for 5.0.2 > and 5.1M1). > >>> > >>> Solution 1: > >>> ========= > >>> > >>> Check if there's only 1 wiki and default to the main wiki whatever the > URL in that case. It's still preferable to get a user started on xwiki and > more important than the use case found by Edy which is an edge case. > >>> > >>> Solution 2: > >>> ========= > >>> > >>> Since the default config is path-based, stop fallbacking to > domain-based when no descriptor is found and always fallback to the main > wiki instead. > >>> > >>> This option should solve the problem of getting started for users and > at the same time not have the problem raised by Edy. The only downside > would be users who had configured their subwiki in path-based (default) but > with domains, which is not the normal way anyway: they should configure it > in domain-based if they wish to use domains... > >>> > >>> My preference goes to 2. > >>> > >>> WDYT? Any other solution? > >>> > >>> Thanks > >>> -Vincent > >>> > >>> PS: The reason I suddenly took interest in this topic is because: > >>> * I've helped several users understand why they couldn't access their > wiki in 1 week (I can think of 3) > >>> * I've recoded the new wiki descriptor module and updated the new url > module to handle subwiki aliases and this recoded this algorithm. I'll be > committing this soon now (just finishing some functional tests) > >>> > >>> > >>> _______________________________________________ > >>> devs mailing list > >>> [email protected] > >>> http://lists.xwiki.org/mailman/listinfo/devs > >> > >> > >> > >> -- > >> Thomas Mortagne > > > > > > > > -- > > Thomas Mortagne > > > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
