On Thu, Jan 23, 2014 at 4:22 PM, Sergiu Dumitriu <[email protected]> wrote:
> On 01/23/2014 10:18 AM, Denis Gervalle wrote: > > On Thu, Jan 23, 2014 at 2:49 PM, Sergiu Dumitriu <[email protected]> > wrote: > > > >> On 01/23/2014 06:11 AM, [email protected] wrote: > >>> Hi devs, > >>> > >>> I’m working to fix http://jira.xwiki.org/browse/XWIKI-9910 but before > I > >> can fix it we need to decide something since we have 2 possibilities. > >>> > >>> - Option 1: The hidden flag is set at document translation level which > >> means when the user check the hidden flag it’s only for the current > >> translation > >>> - Option 2: The hidden flag is set at the default document level (not > >> set at translated doc level) which means there’s a single hidden flag > >>> > >>> ATM the problem with XWIKI-9910 is that when the user checks the > hidden > >> flag, it’s set at the translation level but when a translation is > displayed > >> the value shown is the one from the default document. > >>> > >>> Option 1 offers more use cases but: > >>> - users may be surprised > >>> - users need to be careful to edit the default doc if they wish to set > >> the doc as hidden for all translations > >>> > >>> I’m not sure what option I prefer. Initially I was more for option 2 > but > >> I’m now hesitating and leaning more towards option 1. Note that option 2 > >> means one more DB upate when saving a translated doc. > >> > >> I'm not sure 2 is going to work that easily, since by default queries > >> don't filter by the "translation" flag. 2 means that we have to change > >> every query (impossible if we count user queries), or the way the search > >> APIs work (backwards incompatible). > >> > >> So +1 for 1. > >> > >> Use case: the master document is visible, and it is an important one > >> (legal contract, license, official documentation...). Translations are > >> being worked on. While a translation isn't approved, they'd like it to > >> be hidden. > >> > > > > This is not a valid use case, it could be better solve using access > rights. > > Hiding document is not really for user document but is there for hiding > > technical document from search results and other navigations. It is for > > sure a bad practice to use it to control a publishing workflow IMO. > > > > It is a _valid_ use case, but it is not a very good one. I agree that > there are much better ways of restricting access to documents than the > hidden flag. > I mean it is not valid because there is a far better practice with rights I am not against a per translation solution if it prove to be really useful, but currently I cannot find an interesting use case, only potential issues and UI complexity. > > And access rights can't help here, since rights are objects, which can > only be attached to the main document. > I do not get that point ? > > > > >> > >> UX proposal: > >> > >> - when a translation is created, it copies the hidden field from the > master > >> - when a user changes the master's hidden status, a dialog shows up > >> asking if all the translations should be changed as well or not > >> - when a user changes a translation's hidden status, a dialog shows up > >> asking for a confirmation if it's different from the master, warning > >> about the possible issues caused by a difference in the flag > >> - we display the hidden status of the translation in the UI > > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
