Hi, What I don`t fully understand is why changing a skin should affect the UI tests of an application?
Page objects should be specific to the application's UI elements that are custom coded to reflect the state of and to perform operations on the UI elements of the tested application only. These UI elements should generally be located inside the document's rendered content and should be minimally impacted by a skin change. For me, an application should be limited as much as possible to the document's rendered content. When we are not testing applications, but the UI of XWiki itself, then indeed, perhaps we should have both skin-specific page-objects and tests. So my question is: How much is the current skin change affecting our UI tests and at which level? Are application UI tests affected as well? Thanks, Eduard On Tue, Aug 19, 2014 at 9:02 PM, [email protected] <[email protected]> wrote: > > > > > On 19 Aug 2014 at 19:53:54, Sergiu Dumitriu ([email protected](mailto: > [email protected])) wrote: > > > On 08/19/2014 12:12 PM, [email protected] wrote: > > > Hi devs, > > > > > > ATM our selenium2-based test fwk for functional tests only supports > one skin (Colibri). > > > > > > Guillaume is currently fixing the functional tests by changing our > test framework to work with Flamingo. > > > > > > After his changes are made our framework won’t work anymore with > Colibri. > > > > > > The question is: > > > * Is this ok? > > > * Do we want to change the framework to support multiple skins? In > this case we would need to introduce Interfaces everywhere, for each Page > Object to have various implementations. > > > > > > One example of difference is Hover vs Clicking for the top level > menus. Another example is that we don’t have anymore a contentmenu; it’s 3 > buttons. Etc. > > > > > > Any opinion? > > > > Tests should work on different skins. At some point we did have some > > support for skins, in the old xe-test-selenium module [1], but this > > feature didn't survive the pageobjects revolution. > > Yes (I coded it). The main reason it didn’t survive is because several > skins didn’t survive and in the end we’ve been supporting only 1 skin for > years. > > The question are: > 1) whether we’re going to support several skins in the future or not? > We’ve already said we’re going drop Colibri when Flamingo is ready. > Supporting several skins in the test framework is a lot of effort. > 2) if we want to support several skins in the test fwk when is the right > time. ATM we’re late for Flamingo as the default skin for 6.2 and doing > this in 6.2 would mean postponing 6.2’s release by at least 1 to 2 weeks. > > Thanks > -Vincent > > > [1] > > > https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-test/xwiki-enterprise-test-selenium/src/test/it/org/xwiki/test/selenium/framework > > > > -- > > Sergiu Dumitriu > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
