Hi, +1 for only testing on Flamingo.
Thanks, Manuel On Thu, Aug 21, 2014 at 12:57 PM, Denis Gervalle <[email protected]> wrote: > On Wed, Aug 20, 2014 at 4:01 PM, [email protected] <[email protected]> > wrote: > > > > > > > > > > > On 20 Aug 2014 at 15:55:59, Marius Dumitru Florea ( > > [email protected](mailto:[email protected])) > > wrote: > > > > > I'm fine with running the functional tests only for the default skin. > > > Note that although we support many browsers we run the functional > > > tests only for Firefox. > > > > Which is bad and not something we want ;) > > > > We want to have test on all browser with as many skin as possible, > including test of all combination of migrated version, and ... well, what > we want is not really compatible with true reality :) > > So, taking into account our team, I do not think we can afford the support > of more than one skin. In practice, I doubt those that see our new skin > will want to stick with colibri for long, and those that will, will also > stick with the old xwiki version they have. The support for both colibri > and flamingo in parallel is also short term, so unless I over estimate the > workload, I am +1 to only support one skin in functional tests, and to also > put some reserves on the usage of colibri in upcoming versions. > > Thanks, > > > > > > Thanks > > -Vincent > > > > > So I think it's ok if we continue supporting > > > the Colibri skin for a few versions even if we stop running the > > > functional tests on it (because it's not the default skin any more). > > > > > > Thanks, > > > Marius > > > > > > On Tue, Aug 19, 2014 at 7:12 PM, [email protected] wrote: > > > > Hi devs, > > > > > > > > ATM our selenium2-based test fwk for functional tests only supports > > one skin (Colibri). > > > > > > > > Guillaume is currently fixing the functional tests by changing our > > test framework to work with Flamingo. > > > > > > > > After his changes are made our framework won’t work anymore with > > Colibri. > > > > > > > > The question is: > > > > * Is this ok? > > > > * Do we want to change the framework to support multiple skins? In > > this case we would need to introduce Interfaces everywhere, for each Page > > Object to have various implementations. > > > > > > > > One example of difference is Hover vs Clicking for the top level > > menus. Another example is that we don’t have anymore a contentmenu; it’s > 3 > > buttons. Etc. > > > > > > > > Any opinion? > > > > > > > > Thanks > > > > -Vincent > > _______________________________________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/mailman/listinfo/devs > > > > > > -- > Denis Gervalle > SOFTEC sa - CEO > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
