> > > I'm fine with running the functional tests only for the default skin. > > +1 > > > Note that although we support many browsers we run the functional > > tests only for Firefox. So I think it's ok if we continue supporting > > the Colibri skin for a few versions even if we stop running the > > functional tests on it (because it's not the default skin any more). > > +1 for this as well. Andreea has been doing manual tests on Colibri in > parallel with Flamingo and will probably continue to do so for a few > more versions. >
I agree with Silvia on this. So, I'm +1. Thanks, Andreea On Thu, Aug 21, 2014 at 11:33 AM, Silvia Rusu <[email protected]> wrote: > Hi, > > On Wed, Aug 20, 2014 at 4:55 PM, Marius Dumitru Florea > <[email protected]> wrote: > > I'm fine with running the functional tests only for the default skin. > > +1 > > > Note that although we support many browsers we run the functional > > tests only for Firefox. So I think it's ok if we continue supporting > > the Colibri skin for a few versions even if we stop running the > > functional tests on it (because it's not the default skin any more). > > +1 for this as well. Andreea has been doing manual tests on Colibri in > parallel with Flamingo and will probably continue to do so for a few > more versions. > > Thanks, > Silvia > > > > > Thanks, > > Marius > > > > On Tue, Aug 19, 2014 at 7:12 PM, [email protected] <[email protected]> > wrote: > >> Hi devs, > >> > >> ATM our selenium2-based test fwk for functional tests only supports one > skin (Colibri). > >> > >> Guillaume is currently fixing the functional tests by changing our test > framework to work with Flamingo. > >> > >> After his changes are made our framework won’t work anymore with > Colibri. > >> > >> The question is: > >> * Is this ok? > >> * Do we want to change the framework to support multiple skins? In this > case we would need to introduce Interfaces everywhere, for each Page Object > to have various implementations. > >> > >> One example of difference is Hover vs Clicking for the top level menus. > Another example is that we don’t have anymore a contentmenu; it’s 3 > buttons. Etc. > >> > >> Any opinion? > >> > >> Thanks > >> -Vincent > >> _______________________________________________ > >> devs mailing list > >> [email protected] > >> http://lists.xwiki.org/mailman/listinfo/devs > > _______________________________________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
