Hi devs,

I’d like to propose that we use the strategy described at 
https://github.com/junit-team/junit/wiki/Exception-testing (thanks to Lyes for 
pointing out this page to me).

For example:

    @Test
    public void sendSynchronousWithErrors() throws Exception
    {
...
        this.thrown.expect(MessagingException.class);
        this.thrown.expectMessage("Some messages have failed to be sent for the 
following reasons: "
            + 
"[[[errorsummary1],[errordescription1]][[errorsummary2],[errordescription2]]]");

        this.mocker.getComponentUnderTest().send(Arrays.asList(message), 
session);
    }

I feel it’s slightly better than our current idiom based on try/catch. One 
advantage is that we cannot forget to put the fail().

WDYT?

Thanks
-Vincent


_______________________________________________
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to