On Tue, Mar 24, 2015 at 4:38 PM, Marius Dumitru Florea <[email protected]> wrote: > On Fri, Mar 20, 2015 at 12:57 PM, [email protected] <[email protected]> > wrote: >> Hi devs, >> >> In xwiki-enteprise we have XWiki.RequiredRightClass. We’ve started >> discussing it in the past in the “Split XE pages” mail thread and I’d like >> to move forward. >> >> So we need to decide what to do about it. Several options: >> >> * We discussed moving it to xwiki-platform-administration but it shouldn’t >> go there IMO since we’re trying to make this module almost empty (just >> providing the extension points mechanism) and have admin features dispatched >> in the modules providing them. Also it would mean forcing unnecessary >> dependencies on xwiki-platform-administration from several modules (6-7 >> right now). >> * It could go in a new xwiki-platform-security-ui module. >> * It could be moved to Java but we don’t have a clear policy nor decision if >> we want to favor xclasses written in java or opposite, decide that we don’t >> want that and move away from XClasses in Java. So we’d need to decide this >> first. >> * We could also simply remove it! Rationale: >> ** I don’t think we’re using that information much and its need is supposed >> to go away once signed scripts is there >> ** There’s no way to force pages requiring PR to add such an XObject and >> thus it’s not done consistently >> ** We don’t even have a page listing all pages requiring PR and even if we >> had one I’m not exactly what it would bring. I guess the idea was to make it >> simpler to install/upgrade XWiki but we’ve fixed this already in the Wiki >> Creation Wizard for example so the need is less now. >> >> So overall I’m more in favor of dropping this experiment which IMO wasn’t >> very successful. >> > >> WDYT? > > Isn't this an API breakage? It's not much different than removing a > method from a script API without a deprecation phase. An application > like Admin Tools [1] that uses this xclass and expects it to be > present, will stop working (as expected) after an upgrade of XWiki.
As long as the objects are not deleted, deleting the class should not change much to this example at least. It's just that you won't be able to add new object or edit these object with the object editor. > > Thanks, > Marius > > [1] > https://github.com/xwiki-contrib/application-admintools/blob/master/src/main/resources/Admin/CheckProgrammingRights.xml#L327 > >> >> Thanks >> -Vincent >> >> >> >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
