> On 16 Apr 2018, at 18:19, Vincent Massol <vinc...@massol.net> wrote:
> 
> 
> 
>> On 16 Apr 2018, at 16:00, Vincent Massol <vinc...@massol.net> wrote:
>> 
>> Hi,
>> 
>> I’ve posted the following on matrix/IRC.
>> 
>> Friday:
>> 
>> * Guys we regressed in global TPC from  2017-11-09 to 2018-04-03 :(
>> * From 76.28% to 75.88%
>> * we need to analyze more in details now to understand why
>> * (and whether the report is correct or not)
>> * PDF Report: https://up1.xwikisas.com/#mJ0loeB6nBrAgYeKA7MGGw
>> * Examples:
>> ** com.xpn.xwiki.internal.store from 97.6% to 89.32%
>> ** com.xpn.xwiki.internal.file from 67.9% to 9.87%  - that's huge maybe some 
>> refactoring
>> ** org.xwiki.url.internal from 86.99% to 63.69%
>> 
>> Today:
>> 
>> * Note that I have 2 reasons for checking our TPC:
>> ** Globally it has to go up every year and we've gone down since nov 2017
>> ** For STAMP we need to show an increase in TPC and we had a nice +2.2% 
>> increase from 2016 to 2017 but we've gone down now and we need to go up, to 
>> go to +3 or/ 4% at end of 2018

[snip]

Analysis 3: We should add some unit tests for org.xwiki.resource.events 
classes. Right now there’s no tests and they’re tested indirectly only. That 
gets them to 52% but it’s a bit low for new codfe (new code and easy to test 
like this should get at least 80% coverage). For ex here it would be very easy 
to add some tests for hashcode/equals.

See 
http://maven.xwiki.org/site/clover/20180403/clover-commons+rendering+platform-20180403-1915/org/xwiki/resource/events/pkg-summary.html

I’ll let Thomas comment since this is some code he added.

Thanks
-Vincent

Reply via email to