Hi Fawad, Thank you also for your hard work and I'm glad you had a nice time during GSOC.
Thanks also for providing some status and I will be waiting to install the latest version and see the feedback the others community members will have. Caty On Tue, Sep 3, 2019 at 9:28 PM Fawad Ali <m.fawaadal...@gmail.com> wrote: > Hi all, > Hope you are doing good. > > I just received the mail from Google for the final evaluations. Thanks for > all the kind words. It is an absolutely wonderful experience to work on > this project! > > Regarding the release, I would like to inform you that the documentation > for releasing the second version was actually prepared during the GSoC > period. Due to several unprecedented issues like the leaflet webjar not > loading up (even with no change in dependencies) the release was postponed > as opposed to my plan to release the application on the last day of GSoC. > After that, several issues were opened by Stephane. It is a mistake on my > part for not taking these unprecedented circumstances into account but the > release will surely be done sometime around this week. > > Thanks, > Fawad > > > On Sun, Sep 1, 2019 at 10:51 PM Stéphane Laurière <slauri...@xwiki.com> > wrote: > >> Caty, Fawad, all, >> >> > Hi, >> > >> > What I would like is a working version of the application that can be >> installed, as a final version that can be linked and showed the work done. >> >> Indeed, it'd be a cool achievement. >> >> > On Sun, Sep 1, 2019 at 5:48 PM Stéphane Laurière <slauri...@xwiki.com >> <mailto:slauri...@xwiki.com>> wrote: >> > >> > Hi Caty, Fawad, all, >> > >> > There's been much progress on the app recently by Fawad, that's >> great, I spotted a few issues that are likely to block the release indeed, >> not many, most of the entries I created on Jira today are improvement >> suggestions for upcoming releases. The three key ones imho are: >> > >> > - JavaScript instability on map at Demo.WebHome >> https://jira.xwiki.org/browse/INTMAP-76 – In case this is too long to >> fix, I'd suggest we remove the indoor feature from the demo for the release >> itself, so that we get a 100% working demo, what do you think? Obviously >> fixing it would be even better, let me know if you need help Fawad. >> > >> > - Leaflet configuration issue on installation >> https://jira.xwiki.org/browse/INTMAP-74 – Removing the version number >> seems to work fine with all recent XWiki versions and matches the >> WebjarScriptService documentation, to be tested further, and we will need >> to investigate what fails with the continuous integration, but not a >> blocker issue imho. >> > >> > - JSON format errors on map at Demo.WebHome >> https://jira.xwiki.org/browse/INTMAP-75 >> > >> > Fixing the overflow issue would be nice as well since it would >> enhance the first live contact of the user with the app: >> https://jira.xwiki.org/browse/INTMAP-85 – Unsetting the "overflow" rule >> of #xwikicontent fixes the issue but may introduce others. The Mozilla >> documentation page >> https://developer.mozilla.org/en-US/docs/Web/CSS/overflow states that >> "overflow" is useful only when a height is set or "white-space" set to >> "nowrap". I'm wondering in which cases the height of #xwikicontent needs to >> be set, or the "white-space" option. Do you have any idea Caty, all? >> > >> > >> > We should not remove the overflow from #xwikicontent. Make sure the map >> is clearing the floats, but I find the issue to be minor. >> >> Sure, we don't want to remove the overflow, I was just wondering about >> its exact role. I'm convinced it's there for a good reason. I also agree >> with you the issue is minor. Thanks for your suggestion about clearing the >> float, I gave it a try with no luck so far but I'm for from having a deep >> understanding of CSS, just a humble admirer >> >> Chees >> >> Stéphane >> >>
