Your message dated Sat, 15 Sep 2012 19:47:47 +0000 with message-id <[email protected]> and subject line Bug#686247: fixed in devscripts 2.12.3 has caused the Debian Bug report #686247, regarding debdiff exits with wrong exit code (regression after security update) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 686247: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686247 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: devscripts Version: 2.10.69+squeeze2 Severity: normal Tags: patch As of devscripts 2.10.69+squeeze2 in squeeze and (judging from the changelog) 2.11.4 in sid, debdiff returns an exit code 1 when it finds no differences between binary packages. Note that this is a regression in squeeze, and breaks scripts relying on the debdiff exit code. Trivial patch is attached. Nikolaus PS. I'm forwarding this from the mailing list to the BTS so that it doesn't get ignored. -- System Information: Debian Release: 6.0.5 APT prefers stable APT policy: (500, 'stable') Architecture: i386 (i686)>From 2a1bff244d89c6ff15cbe7553564eb45f90997ac Mon Sep 17 00:00:00 2001 From: Nikolaus Schulz <[email protected]> Date: Thu, 23 Aug 2012 21:46:14 +0200 Subject: [PATCH] Fix debdiff exit code (regression) Commit 9cbe605 "debdiff: fix CVE-2012-2012 [...]" broke the exit code of debdiff, at it made wdiff_control_files return 1 if wdiff found no differences in the control files, which in turn made debdiff exit with an exit code of 1. --- scripts/debdiff.pl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/scripts/debdiff.pl b/scripts/debdiff.pl index 7857836..20a0ced 100755 --- a/scripts/debdiff.pl +++ b/scripts/debdiff.pl @@ -1034,6 +1034,7 @@ sub wdiff_control_files($$$$$) my $msg = ucfirst($cf) . " files$usepkgname: wdiff output"; print "\n", $msg, "\n", '-' x length $msg, "\n"; print $wdiff; + $status = 1; } else { my @output; @output = split /\n/, $wdiff; @@ -1041,8 +1042,8 @@ sub wdiff_control_files($$$$$) my $msg = ucfirst($cf) . " files$usepkgname: lines which differ (wdiff format)"; print "\n", $msg, "\n", '-' x length $msg, "\n"; print join("\n",@output), "\n"; + $status = 1; } - $status = 1; } } -- 1.7.2.5
--- End Message ---
--- Begin Message ---Source: devscripts Source-Version: 2.12.3 We believe that the bug you reported is fixed in the latest version of devscripts, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. James McCoy <[email protected]> (supplier of updated devscripts package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Sat, 15 Sep 2012 15:23:41 -0400 Source: devscripts Binary: devscripts Architecture: source amd64 Version: 2.12.3 Distribution: unstable Urgency: medium Maintainer: Devscripts Devel Team <[email protected]> Changed-By: James McCoy <[email protected]> Description: devscripts - scripts to make the life of a Debian Package maintainer easier Closes: 583750 683231 686247 687584 Changes: devscripts (2.12.3) unstable; urgency=medium . [ Benjamin Drung ] * licensecheck: - Don't truncate other licenses on Public domain or WTFPL presence. Thanks to Garrett Holmstrom from Fedora for the patch. - Remove trailing spaces. - add --machine option that outputs results in a machine readable format. Thanks to Eric Lavarde for the patch. (Closes: #583750) - Trim trailing period from some GPL notices' versions. . [ Richard W.M. Jones ] * licensecheck: Check OCaml programs by default (*.ml, *.mli). . [ Ville Skyttä ] * Spelling fixes. * licensecheck: Trim trailing comma from some GPL notices' versions. . [ David Prévot ] * licensecheck.1: Consistency fix. * French translation update. . [ Cyril Brulebois ] * getbuildlog: When several build logs are available, save all of them instead of downloading them all but only keeping the oldest. (Closes: #683231) . [ Christoph Berg ] * debcheckout: When --package is given, use this package name rather than trying to guess it from the url. Useful for URLs like http://anonscm.debian.org/bzr/pkg-postgresql/postgresql-9.2/sid-pgapt/. * po4a/Makefile: use po4a --keep=0 so the build system doesn't die with untranslated scripts * dcmd: Reimplement endswith() with case. The original missed quoting and made my brain hurt. * dcmd: Allow digits, underscores, and dots in section/component names. . [ Raphael Geissert ] * dcmd: Allow arguments to contain spaces. (Closes: #687584) . [ James McCoy ] * debdiff: Fix regression in exit code, introduced in 2.11.4. (Closes: #686247) * dget: + Fix CVE-2012-2241 (arbitrary file deletion) + Only match policy-compliant source package names. * dscverify: Fix CVE-2012-2240 (arbitrary code execution) Checksums-Sha1: 63e3e4ce9b5757c31fbb521ab391f7132429e9b7 1659 devscripts_2.12.3.dsc 22dccb53f39ba46afbdc77aadc86e9cd728ec958 789664 devscripts_2.12.3.tar.gz 066859fcf38d61eb4f1e1d7dfee2e4477bb7aaed 708132 devscripts_2.12.3_amd64.deb Checksums-Sha256: b5fe73bb6ae0b6d99f1f345afc609aeb0f7a9e5233009c42e2a2b9974d17f9ca 1659 devscripts_2.12.3.dsc 6714a678b06f751576a3f5e7f5919eb20875d40ba81064a45c7428ff9e77d622 789664 devscripts_2.12.3.tar.gz c7f54f302fcd81e297551380d20fa488a67a700c3a6755897c3712862f9dcd65 708132 devscripts_2.12.3_amd64.deb Files: 3f309dfd4027c1b0ff0217c614be7d71 1659 devel optional devscripts_2.12.3.dsc 3c4883bb2948fcb1c947f41bfe6f0bd9 789664 devel optional devscripts_2.12.3.tar.gz dfc06577f4910ed8a627ad2be38aad0b 708132 devel optional devscripts_2.12.3_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlBU14IACgkQDb3UpmEybUDv5gCfa1546spzsVo0MvihMd3XRxT2 fHUAn23xfsJfIVVn7U/mTZWYelG4AllJ =Osoz -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ devscripts-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel
