Your message dated Tue, 18 Sep 2012 21:28:41 +0000
with message-id <[email protected]>
and subject line Bug#686247: fixed in devscripts 2.10.69+squeeze4
has caused the Debian Bug report #686247,
regarding debdiff exits with wrong exit code (regression after security update)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
686247: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686247
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.69+squeeze2
Severity: normal
Tags: patch

As of devscripts 2.10.69+squeeze2 in squeeze and (judging from the
changelog) 2.11.4 in sid, debdiff returns an exit code 1 when it finds
no differences between binary packages.

Note that this is a regression in squeeze, and breaks scripts relying on
the debdiff exit code.

Trivial patch is attached.

Nikolaus


PS. I'm forwarding this from the mailing list to the BTS so that it
    doesn't get ignored.

-- System Information:
Debian Release: 6.0.5
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
>From 2a1bff244d89c6ff15cbe7553564eb45f90997ac Mon Sep 17 00:00:00 2001
From: Nikolaus Schulz <[email protected]>
Date: Thu, 23 Aug 2012 21:46:14 +0200
Subject: [PATCH] Fix debdiff exit code (regression)

Commit 9cbe605 "debdiff: fix CVE-2012-2012 [...]" broke the exit code of
debdiff, at it made wdiff_control_files return 1 if wdiff found no
differences in the control files, which in turn made debdiff exit with an
exit code of 1.
---
 scripts/debdiff.pl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/scripts/debdiff.pl b/scripts/debdiff.pl
index 7857836..20a0ced 100755
--- a/scripts/debdiff.pl
+++ b/scripts/debdiff.pl
@@ -1034,6 +1034,7 @@ sub wdiff_control_files($$$$$)
 		my $msg = ucfirst($cf) . " files$usepkgname: wdiff output";
 		print "\n", $msg, "\n", '-' x length $msg, "\n";
 		print $wdiff;
+		$status = 1;
 	    } else {
 		my @output;
 		@output = split /\n/, $wdiff;
@@ -1041,8 +1042,8 @@ sub wdiff_control_files($$$$$)
 		my $msg = ucfirst($cf) . " files$usepkgname: lines which differ (wdiff format)";
 		print "\n", $msg, "\n", '-' x length $msg, "\n";
 		print join("\n",@output), "\n";
+		$status = 1;
 	    }
-	    $status = 1;
 	}
     }
 
-- 
1.7.2.5


--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.10.69+squeeze4

We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
James McCoy <[email protected]> (supplier of updated devscripts package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 14 Sep 2012 21:32:38 -0400
Source: devscripts
Binary: devscripts
Architecture: source amd64
Version: 2.10.69+squeeze4
Distribution: squeeze-security
Urgency: high
Maintainer: Devscripts Devel Team <[email protected]>
Changed-By: James McCoy <[email protected]>
Description: 
 devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 686247
Changes: 
 devscripts (2.10.69+squeeze4) stable-security; urgency=high
 .
   * dget:
     + Fix CVE-2012-2241 (arbitrary file deletion)
     + Fix CVE-2012-2242 (arbitrary code execution)
   * dscverify: Fix CVE-2012-2240 (arbitrary code execution)
   * debdiff: Fix regression in exit code, introduced in 2.10.69+squeeze2
     (Closes: 686247)
Checksums-Sha1: 
 e53bea4d14763fabe2d7d88f46eb00c4be5012ab 1475 devscripts_2.10.69+squeeze4.dsc
 9542775d5371cd8ed3308d2797b3a6df9f9a4551 730589 
devscripts_2.10.69+squeeze4.tar.gz
 044aaf5a240f1a8ec920caf9ef8d41c7fdbcd450 648944 
devscripts_2.10.69+squeeze4_amd64.deb
Checksums-Sha256: 
 a76cd2293dac46739e5644714b34c8fd8872fd036af4b6f7aa867fa165c65be9 1475 
devscripts_2.10.69+squeeze4.dsc
 82ecbdd3100e316c56b5ed85a90a7b7f2b8854976a148b9cfc7b3744579ea8b3 730589 
devscripts_2.10.69+squeeze4.tar.gz
 5f7c9c1bb3dd60d6e94e59907186eb312e04d089f528813223133d648adf3dcf 648944 
devscripts_2.10.69+squeeze4_amd64.deb
Files: 
 741e8545a109c9a52eb11b3ea913b942 1475 devel optional 
devscripts_2.10.69+squeeze4.dsc
 745176448937b10c0e84207f691a5016 730589 devel optional 
devscripts_2.10.69+squeeze4.tar.gz
 2c690d412b9282509cc746714fbccd7d 648944 devel optional 
devscripts_2.10.69+squeeze4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlBT5uUACgkQDb3UpmEybUCGpQCgiqLtQT0V4n8AxI45O5QjdPh8
b5MAniILWNJ5VeZkR1IY/ddu7LU9AMG+
=+WDF
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
devscripts-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel

Reply via email to