Am Freitag, den 19.10.2012, 12:15 +1100 schrieb Dmitry Smirnov: > On Fri, 19 Oct 2012 10:51:12 Benjamin Drung wrote: > > Re code style: How should values assigned: "x = 5" or "x=5"? > > > > Whatever you like more -- either way is OK for me, I don't have strong > preference.
I prefer with spaces (x = 5) and this style seems to be used for licensecheck, too. > > Patch 1 and 3 look good. Before applying, I like to see the files that > > triggers the wrong result fixed by these patches. > > > > For patch 1 you can find case in #688843 (as mentioned in patch header). > In my email as of 12 of October I attached licensecheck.pl with embedded test > case for this (see line 1212). I applied patch 1 and tested it against the attached modified-BSD-2-clause.py, but licensecheck still detects it as "BSD (2 clause)". The patch seems to short for the proclaimed change. > Patch 3 is self-explanatory -- it is super-pedantic ;) to ask for license > text for such case but we have it in the licensecheck.pl attached to my email > as of 12 of October test #21 (see line 829). This patch fixes version > detection -- without it GPL-3 may be detected as GPL. Thanks. Applied. -- Benjamin Drung Debian & Ubuntu Developer
# -*- coding: utf-8 -*-
"""
Copyright (c) 2012, Devscripts developers
All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
* The name of the contributors may be used to endorse or promote products
derived from this software without specific prior written permission.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
"""
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devscripts-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/devscripts-devel
