On Sun, 25 Apr 2010 22:26:14 +0900, Andrei Alexandrescu <[email protected]> wrote:

On 04/25/2010 07:20 AM, Masahiro Nakagawa wrote:
I release a serialization library for Phobos(D2).

Project repository: http://www.bitbucket.org/repeatedly/msgpack4d

MessagePack is a binary-based serialization spec.
See official site for details: http://msgpack.sourceforge.net/
Some application replace JSON with MessagePack for performance improvement.

msgpack4d ver 0.1.0 has an equal features with reference implementation.
* Zero copy serialization / deserialization
* Stream deserializer
* Support some D features(Range, Tuple)

Currently, Phobos doesn't have a real serialization module(std.json
lacks some features)
I hope Phobos adopts this library for serialization(std.msgpack or
std.serialization?).

This is great. Code looks very good and it's very generous of you to
offer to contribute it to Phobos.
Thanks!

There are a few details that could be changed to minimize repetition.
For example, SimpleBuffer looks a lot like Appender!(ubyte[]). The
I forgot Appender. I removed SimpleBuffer struct and
used Appender!(ubyte[]) for SimpleBuffer alias.
(I think SimpleBuffer is a better name than Appender!(ubyte[]))

DeflateBuffer and the FileBuffer look like great starting points for
output range artifacts, though e.g. for FileBuffer we should call it
something like BinaryFileWriter (as opposed to TextFileWriter) etc.
Oh, Your point is correct. FileBuffer was not Buffer.

Thank you very much for your code review.
Recent changes are here:
http://www.bitbucket.org/repeatedly/msgpack4d/changesets

I suggest we hold a community review in this group and then most likely
integrate this functionality into Phobos. All - let us know what you think!
Ok, I wait for more reviews.

Reply via email to