On Wednesday, 24 January 2018 at 20:05:42 UTC, Martin Nowak wrote:
On Wednesday, 24 January 2018 at 13:30:42 UTC, Radu wrote:
Just want to bring to your attention a major regression introduced in 2.078, and still present on current master, re. the new __equals template.


Comparing arrays of associative arrays is broken!

Not to be insulting, but hoping for better understanding.

Why, even when the compiler almost directly points to the problem at hand (a missing check for associative arrays :o, https://github.com/dlang/druntime/blob/a66f9fa78f2e295146fb2b3fc8e567983c9e9aed/src/object.d#L3486), doesn't this simply convert to a small pull request to fix the problem (https://github.com/dlang/druntime/pull/2058)?

First of all, thanks for fixing it!

No injuries suffered :D, but here is a list:
- not so confident I understood the whole issue form that implementation, count it as lack of experience. - if wanting to get hands dirty - setting up the whole D dev env (compiler, runtime, tests) on a new machine it takes a while, at least the way I count it. - even if I get that running and make a change that runs on my machine, the outlook of time spent in ping-pong with the reviewers/auto-testers on a PR is daunting.

To wrap it up - it is not `easy as pie` for random contributor to make even a simple PR because of the perceived overhead both in engineering and social aspects, that or I'm to lazy :O

Reply via email to