On 4/2/2013 8:03 PM, Jonathan M Davis wrote:
Too many of them just test a few cases to make sure that the most
obvious stuff works rather than making sure they test corner cases and whatnot.

Currently, the datetime unittest coverage is 95%. Some of the 0 cases suggest low hanging fruit.

Despite what I just said, datetime has one of the highest unittest coverages of any phobos module. Pretty much all of the phobos module unittest coverage testing indicates more work is needed.

Minor perf improvement: the order of the tests in yearIsLeapYear() should be reversed, especially since signed divide is a very slow operation, and it is called 20 million times by the unittests!!!

Reply via email to