On 3/25/2011 5:59 PM, Denis Koroskin wrote:
On Sat, 26 Mar 2011 00:26:40 +0300, dsimcha <[email protected]> wrote:
On 3/25/2011 3:50 PM, Sean Kelly wrote:
On Mar 24, 2011, at 1:00 PM, dsimcha wrote:
BTW, the TempAlloc module also includes a hash table, hash set and
AVL tree that
are specifically optimized for TempAlloc. Should these be included
in the
submission? The disadvantages I see here is that they are less
generally useful
(possibly too high level for druntime) and that they will make the
review take a
heck of a lot longer.
Are they necessary for TempAlloc to function? If so, I'd add them but
hidden, as I imagine there's more code than you'd want to simply drop
in a private block in core.memory. It may be time for core to get a
core.internal package for this kind of stuff.
No, they are just data structures built on top of TempAlloc and
optimized for it.
I'd love to see them, in a separate module probably.
This suggests two separate proposals. The more I think about it, the
more I think this is the way to go. TempAlloc per se is much more
self-evidently useful than the extra data structures and doesn't need
the extra data structures to work. The extras shouldn't hold up its
inclusion. The extra data structures only use (or only should use; I
don't remember whether I bend this rule) TempAlloc's public API.
Furthermore, I'm not sure they're generally useful enough to belong in
Phobos. I'd like feedback from others when/if TempAlloc is in Phobos
and more people are familiar with it.
