On Monday, September 12, 2011 15:27 Iain Buclaw wrote: > I have been merging Phobos that got released with the latest DMD release > into GDC. And couldn't help but notice this nostalgic error I implemented > a while back: > > std/format.d:1520: Error: cannot goto into catch block > > > Line of concern in phobos: > https://github.com/D-Programming-Language/phobos/blob/master/std/format.d#L > 1539 > > Part of spec which error implements: > http://www.digitalmars.com/d/2.0/statement.html#GotoStatement > > I have discussed such code before and why it should be disallowed: > http://www.digitalmars.com/d/archives/digitalmars/D/Behaviour_of_goto_into_ > catch_blocks._116908.html > > > And I have raised a pull request (though I seem to recall I had commit > access granted a while back - though this was before the move to github): > https://github.com/D-Programming-Language/phobos/pull/253
Regardless of whether you have commit access, anything other than really trivial changes (such as updates to the changelog) should still go through pull requests. At this point having commit access is more about being able to merge in other people's pull requests that have been adequately reviewed than being able to commit your own changes. However, if you want commit access again, then ping Walter about it, and he should be able to give you commit access. - Jonathan M Davis
