== Quote from dsimcha ([email protected])'s article > == Quote from Iain Buclaw ([email protected])'s article > > I have been merging Phobos that got released with the latest DMD release > > into > > GDC. > Great. I was wondering what happened here since you usually merge Phobos and > DMD > at the same time, and I'm very excited that the last few showstopper bugs got > fixed and GDC may actually be usable now.
A very particular change to arraytypes in the frontend was the reason for that. :o) > > And I have raised a pull request (though I seem to recall I had commit > > access > > granted a while back - though this was before the move to github): > > https://github.com/D-Programming-Language/phobos/pull/253 > Generally you should use pull requests even if you have commit access, so > that the > code gets reviewed by at least one other person. This has led to major > improvements in the code quality in Phobos. The exception is for "trivial" > things. > There's a little disagreement about where the line should be drawn. I draw > it at > simple one- or a few-liner bug fixes in code I understand well, and reverting > recent changes that cause build problems. These and anything simpler, I push > directly. Anything more complicated, I think review is worthwhile. Others > seem > to think that basically any change to actual code is non-trivial, though I > think > this is excessively bureaucratic and would only follow it if there was a very > strong consensus and a written rule in our dev guidelines. OK, thanks.
