On Thu, 2004-04-22 at 18:53 +0300, Ville Syrj�l� wrote: > On Thu, Apr 22, 2004 at 06:22:32PM +0300, Lauri Myll�ri wrote: > > Hi, > > > > I've had problems displaying interlaced material on G450 tvout. I'm > > using DirectFB and MPlayer from CVS. > > > > The fieldparity setting doesn't seem to work. Without it, output is > > mostly ok, but sometimes the fields get inverted.
I have been having this problem for months now but have just not wanted
to bother Ville with it. I don't feel like it's ever been exactly quite
right.
> > With either (top or
> > bottom) setting, output seems to have problems all the time.
> <snip>
> > It seems that mcrtc2->field is always 0, regardless of parameters given
> > to -vo directfb or -vo dfbmga. DLOP_FIELD_PARITY is set, though.
>
> Indeed. Should be fixed now...
I tried to apply just the patch from CVS:
diff -u DirectFB/gfxdrivers/matrox/matrox_crtc2.c:1.26
DirectFB/gfxdrivers/matrox/matrox_crtc2.c:1.27
--- DirectFB/gfxdrivers/matrox/matrox_crtc2.c:1.26 Tue Mar 30 21:13:42 2004+++
DirectFB/gfxdrivers/matrox/matrox_crtc2.c Thu Apr 22 17:49:59 2004
@@ -244,6 +244,8 @@
/* remember configuration */
mcrtc2->config = *config;
+ mcrtc2->field = !config->parity;
+
crtc2_calc_regs( mdrv, mcrtc2, config, surface );
crtc2_calc_buffer( mdrv, mcrtc2, surface );
to my somewhat old (somewhere between 0.9.20 and CVS HEAD) source pool
and I got a:
gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../include -I../../src -D_REENTRANT -Wall -O3
-ffast-math -pipe -Werror-implicit-function-declaration -Wp,-MD,.deps/matrox_crtc2.pp
-c matrox_crtc2.c -fPIC -DPIC -o matrox_crtc2.lo
matrox_crtc2.c: In function `crtc2SetConfiguration':
matrox_crtc2.c:263: error: structure has no member named `parity'
make[3]: *** [matrox_crtc2.lo] Error 1
I guess my source pool is too old for the patch, but I am reluctant to
bit off on updating my whole DirectFB to the current CVS HEAD.
Is the above fix relevant at all to rev. 1.18
gfxdrivers/matrox/matrox_crtc2.c?
b.
signature.asc
Description: This is a digitally signed message part
