Attilio Fiandrotti schrieb:
> Denis Oliver Kropp wrote:
>> Thanks for the patch!
>>
>> It works, but there are some issues (sorted by severity):
> 
> The attached, updated, patchfile fixes somes of the issues reported in 
> the first patch

Thanks for the update! I'll check it out later.

>> Normal button down or up events get lost sometimes.
> 
> could not reproduce this: normal butons could correctly be used to drag 
> things while moving the finger on the touchpad

Double clicking the terminal title was not always working.

In df_input you could also see that.

>> Tapping doesn't produce clicks and can even make the cursor jump.
> 
> implemented, works well in gtk apps

:-)

>> Sensitivity is quite high. Landing as gentle as I could makes the
>> cursor jitter already.
> 
> this was addressed by rising the scalinf factor and making motion 
> proportional to finger pressure, but a smarter implemetation, like X 
> driver does, would be good.

What does it do?

> One could decide dynamics accordingly to the last n x or y moves, but 
> this may require soe kind of buffer.

Accelerating acceleration :)

Constant movement should stay constant movement, of course.

>> Also the movement itself, once on the ground, might be too fast
>> for some users. I don't know about touchpads, but I guess there
>> are differences between the models regarding the resolution of
>> incoming values. Is there a way to query that?
> 
> i've not looked at this yet :(

Let's see when we need it.

>> Finally, I'm thinking about what this patch would do to other
>> vendor's touchpads. Are they handled by the same code? Then the
>> functions etc. should not contain synaptics in their names.
>> Otherwise there should be a detection if it's really a synaptics
>> device.
> 
> i've replaced the synaptic prefixes with touchpad, i don't know if all 
> synaptic-like devices have synaptics in their name.

I thought about touchpads from other companies which shouldn't have
it in their devices' name :)

> Do you belive a touchpad is now at least usable?

I'll look at the click issue, but I'm going to commit your patch anyhow. 
Thanks!

-- 
Best regards,
   Denis Oliver Kropp

.------------------------------------------.
| DirectFB - Hardware accelerated graphics |
| http://www.directfb.org/                 |
"------------------------------------------"

_______________________________________________
directfb-dev mailing list
[email protected]
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev

Reply via email to