Stefan Lucke wrote:
> On Dienstag 12 Dezember 2006 21:36, Claudio Ciccani via CVS wrote:
>> CVSROOT: /cvs/directfb
>> Module name: DirectFB
>> Changes by: klan 20061212 21:36:06
>>
>> Modified files:
>> gfxdrivers/unichrome: uc_primary.c
>>
>> Log message:
>> Check pixelformat when enabling alphachannel (it should be AiRGB, I think).
>
> Can you please backout this change ?
The change was required since the format supported by the layer is not
ARGB, but AiRGB, and if an application sets the format to ARGB, it
expects a non-inverted alpha channel.
Returning an unsupported format is, of course, an error (BUG) and the
application should never be forced to check which driver is running to
detect whether the driver does buggy things.
>
> Background is that vdr-softdevice uses ARGB as default pixelformat for
> all OSD-drawing on graphic layer (see problem report below).
> Handling for inverted alpha for unichrome is done separately in softdevice.
>
> To my opinion, signalling that a graphic device requires inverted alpha
> handling, should be done in a separate API call.
We could add DLCAPS_INVERTED_ALPHA to make the format detection easier.
>
> At the moment I'm just low with time for changing softdevice drawing logic.
>
I think that you only need to check whether SetConfiguration fails with
ARGB format and set the format to AiRGB in that case.
--
Regards,
Claudio Ciccani
[EMAIL PROTECTED]
http://directfb.org
http://sf.net/projects/php-directfb
_______________________________________________
directfb-dev mailing list
[email protected]
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
