On Tue, Feb 01, 2005 at 08:30:07PM +0200, Tomi Hautakoski wrote: > On Tue, 1 Feb 2005, Ville Syrj�l� wrote: > > >I've attached two hackish patches (one for the kernel and the other for > >DirectFB) that move field parity handling completely to the kernel. That > >should guarantee better timing. Give them a try and see if they help. > > Hmm, which kernel this patch is against? I patched 2.4.28 and got:
~2.6.10 > make[4]: Entering directory `/usr/src/linux-2.4.28/drivers/video/matrox' > gcc -D__KERNEL__ -I/usr/src/linux-2.4.28/include -Wall -Wstrict-prototypes > -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer > -pipe -mpreferred-stack-boundary=2 -march=i686 -nostdinc -iwithprefix > include -DKBUILD_BASENAME=matroxfb_base -DEXPORT_SYMTAB -c > matroxfb_base.c > matroxfb_base.c: In function `matroxfb_ioctl': > matroxfb_base.c:1272: `argp' undeclared (first use in this function) > matroxfb_base.c:1272: (Each undeclared identifier is reported only once > matroxfb_base.c:1272: for each function it appears in.) > make[4]: *** [matroxfb_base.o] Error 1 Replace + if (copy_from_user(&addr, argp, sizeof(addr))) with + if (copy_from_user(&addr, (struct matroxioc_crtc2_address*)arg, sizeof(addr))) and I think it should work with 2.4. -- Ville Syrj�l� [EMAIL PROTECTED] http://www.sci.fi/~syrjala/
